[Review] Correct unused parameter warnings in rolling algorithms

[robertmaynard]

Starting in CUDA 11.3, nvcc will start to unconditionally warn about unused parameters on functions/methods that are in anonymous namespaces.

[ttnghia]

It is a good/better practice to use Type /*variable_name*/ instead of removing the unused variable name entirely. Having the name there will let us a better hint about what is sitting at the parameter position.

[robertmaynard]

It is a good/better practice to use Type /*variable_name*/ instead of removing the unused variable name entirely. Having the name there will let us a better hint about what is sitting at the parameter position.

I don't mind updating the approach but it would be great to have a consistent style. When I brought this up on slack people wanted me to drop the unused names so they can't go out of sync, so that is what I used for both of the open PR's and #8239, and #8232

[harrism]

Does NVCC respect the C++17 ``[[maybe_unused]]` attribute? https://en.cppreference.com/w/cpp/language/attributes/maybe_unused

[ttnghia]

Does NVCC respect the C++17 ``[[maybe_unused]]` attribute? https://en.cppreference.com/w/cpp/language/attributes/maybe_unused

I think it should, as C++ standard is the same for both host and device code compilation.

[robertmaynard]

Does NVCC respect the C++17 ``[[maybe_unused]]` attribute? https://en.cppreference.com/w/cpp/language/attributes/maybe_unused

I think it should, as C++ standard is the same for both host and device code compilation.

This warning is generated by a component of the CUDA compiler unconditionally when invoked independent of the standard level, or if the code is host or device. In addition this component currently doesn't respect any [[maybe_unused]] attributes and will generate these warnings.

So for now we have to jump through these hoops.

[robertmaynard]

rerun tests

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@a9f15b8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7f0c29a differs from pull request most recent head 31eb643. Consider uploading reports for the commit 31eb643 to get more accurate results

@@               Coverage Diff               @@
##             branch-21.08    #8390   +/-   ##
===============================================
  Coverage                ?   82.84%           
===============================================
  Files                   ?      109           
  Lines                   ?    17913           
  Branches                ?        0           
===============================================
  Hits                    ?    14840           
  Misses                  ?     3073           
  Partials                ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f15b8...31eb643. Read the comment docs.

[robertmaynard]

@gpucibot merge