Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for strings/fixed_point convert APIs #8417

Merged

Conversation

davidwendt
Copy link
Contributor

Reference #5698
This PR adds benchmark tests for cudf::strings::to_fixed_point and cudf::strings::from_fixed_point.
The benchmarks include measurements for both decimal32 and decimal64 types.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 1, 2021
@davidwendt davidwendt self-assigned this Jun 1, 2021
@davidwendt davidwendt requested a review from a team as a code owner June 1, 2021 14:33
@github-actions github-actions bot added the CMake CMake build issue label Jun 1, 2021
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, other than the two comments (maybe it isn't possible)

cpp/benchmarks/string/convert_fixed_point_benchmark.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/string/convert_fixed_point_benchmark.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@48a2663). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8417   +/-   ##
===============================================
  Coverage                ?   82.83%           
===============================================
  Files                   ?      109           
  Lines                   ?    17901           
  Branches                ?        0           
===============================================
  Hits                    ?    14828           
  Misses                  ?     3073           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a2663...3aaa2f9. Read the comment docs.

@harrism
Copy link
Member

harrism commented Jun 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 347cf49 into rapidsai:branch-21.08 Jun 3, 2021
@davidwendt davidwendt deleted the benchmark-strings-fixedpoint branch June 3, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants