Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Unpin dask version on CI #8425

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR will unpin dask versions that are fetched in CI.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 1, 2021
@galipremsagar galipremsagar self-assigned this Jun 1, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner June 1, 2021 23:38
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@f31a094). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8425   +/-   ##
===============================================
  Coverage                ?   82.83%           
===============================================
  Files                   ?      109           
  Lines                   ?    17901           
  Branches                ?        0           
===============================================
  Hits                    ?    14828           
  Misses                  ?     3073           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31a094...b24b7d1. Read the comment docs.

@jakirkham
Copy link
Member

Should we fold this change into PR ( #8426 )?

@galipremsagar
Copy link
Contributor Author

Should we fold this change into PR ( #8426 )?

we could, but then I'm not sure how long the dask upstream PR would take to be merged, so better to let our CI work using dask main branch irrespective of make_meta changes

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c179b7d into rapidsai:branch-21.08 Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants