Add accurate hash join size functions #8453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emporary solution
PointKernel
added
3 - Ready for Review
jrhemstad
reviewed
Jun 7, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8453 +/- ##
================================================
+ Coverage 82.53% 82.91% +0.38%
================================================
Files 110 110
Lines 17739 18094 +355
================================================
+ Hits 14640 15002 +362
+ Misses 3099 3092 -7
Continue to review full report at Codecov.
|
davidwendt
reviewed
Jun 8, 2021
jrhemstad
approved these changes
Jun 9, 2021
robertmaynard
approved these changes
Jun 9, 2021
revans2
approved these changes
Jun 9, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8237
This PR adds 3 join size APIs (
hash_join::inner_join_size,hash_join::left_join_sizeandhash_join::full_join_size) intohash_joinclass, one for each type of join that returns the exact number of matches with the specified probe table. It completely removed the deprecated size estimation logic in the current implementation.Also, this PR updates the existing join APIs by adding an optional
output_sizeas an argument. Ifoutput_size.has_value(), we take that value directly for further computation. Otherwise, the target join will internally invoke its corresponding size function.TODO: the currentfull_join_sizeuses a 2-step algorithm similar to what's used inhash_join::full_join. It duplicates certain computations withfull_joinalso thus should be refactored duringcucointegration.