Add in JNI APIs for scan, replace_nulls, group_by.scan, and group_by.replace_nulls [skip ci] #8503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
added
3 - Ready for Review
jlowe
approved these changes
Jun 17, 2021
| * Output values 1, 3, 6 | ||
| * This currently only works for long values that are not nullable as this is currently a | ||
| * very simple implementation. It may be expanded in the future if needed. | ||
| * This is just a convenience method for an inclusive scan ona SUM. |
There was a problem hiding this comment.
Suggested change
| * This is just a convenience method for an inclusive scan ona SUM. | |
| * This is just a convenience method for an inclusive scan on a SUM. |
| package ai.rapids.cudf; | ||
|
|
||
| /* | ||
| * This is analogous to the native 'scan_type'. |
There was a problem hiding this comment.
Nit: It would be nice to define the semantics of inclusive vs. exclusive here.
| package ai.rapids.cudf; | ||
|
|
||
| /* | ||
| * This is analogous to the native 'replace_policy'. |
There was a problem hiding this comment.
Nit: It would be nice to define the semantics of the values here for the Java devs that don't want to dive into the native code.
|
@jlowe I think I have addressed all of your review comments, and updated the comments for a few other Enums too, because I was following a pattern that was already there. |
jlowe
approved these changes
Jun 24, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to do a running window test prototype I added in APIs for
scan,group_by.scan, andgroup_by.replace_nulls. I also added a version ofreplace_nullsthat java was missing. It is still not decided exactly how we are going to support running windows, but I thought I should get these in in case we do want to use them.