Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Make cudf.api.types imports consistent #8571

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

galipremsagar
Copy link
Contributor

We usually don't use relative imports in our code-base, this PR makes the import statements consistent.

@galipremsagar galipremsagar self-assigned this Jun 21, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner June 21, 2021 15:43
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 21, 2021
@galipremsagar galipremsagar added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@f71c6fe). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b34d0a3 differs from pull request most recent head 4f24e65. Consider uploading reports for the commit 4f24e65 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8571   +/-   ##
===============================================
  Coverage                ?   83.00%           
===============================================
  Files                   ?      109           
  Lines                   ?    18215           
  Branches                ?        0           
===============================================
  Hits                    ?    15119           
  Misses                  ?     3096           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f71c6fe...4f24e65. Read the comment docs.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jun 21, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit bbf375b into rapidsai:branch-21.08 Jun 21, 2021
@vyasr
Copy link
Contributor

vyasr commented Jun 21, 2021

@galipremsagar Sorry I didn't get around to this quite fast enough :) I'm fine with this change. I think Keith, @shwina and briefly discussed the question of using relative imports in cudf when I made the types PR and we couldn't remember why cudf chose not to use them but Keith and Ashwin were sure there was some reason. I think the changes slipped through the PR and I've just been copy-pasting elsewhere. I'm still not convinced that we should be avoiding relative imports on principle, but for the sake of consistency I'm fine sticking to absolute imports until we figure out a plan either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants