Add strings support to cudf::shift function #8648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
feature request
ttnghia
requested changes
Jul 2, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8648 +/- ##
===============================================
Coverage ? 10.63%
===============================================
Files ? 109
Lines ? 18659
Branches ? 0
===============================================
Hits ? 1985
Misses ? 16674
Partials ? 0 Continue to review full report at Codecov.
|
ttnghia
approved these changes
Jul 6, 2021
karthikeyann
requested changes
Jul 6, 2021
karthikeyann
approved these changes
Jul 6, 2021
|
Rerun tests. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3915
Added strings specialization logic to the current
cudf::shiftAPI. Rows are shifted by running a transform functions on the offsets and chars child columns to create the output strings column. The gtests are added to thecopying/shift_tests.cpp