Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-processing steps to dask_cudf.groupby.CudfSeriesGroupby.aggregate #8694

Merged

Conversation

charlesbluca
Copy link
Member

Closes #8655

Adds some post-processing steps to Dask-cuDF's series groupby when using the optimized codepaths for aggregations, to match those done by Dask. These ensure that a dask_cudf.Series is always returned for the groupby operation, which was a problem observed in #8655.

@charlesbluca charlesbluca added bug Something isn't working 3 - Ready for Review Ready for review by team dask-cudf non-breaking Non-breaking change labels Jul 8, 2021
@charlesbluca charlesbluca requested a review from a team as a code owner July 8, 2021 20:53
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@a5427d2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 14bbd44 differs from pull request most recent head 185f96f. Consider uploading reports for the commit 185f96f to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8694   +/-   ##
===============================================
  Coverage                ?   10.67%           
===============================================
  Files                   ?      109           
  Lines                   ?    18667           
  Branches                ?        0           
===============================================
  Hits                    ?     1993           
  Misses                  ?    16674           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5427d2...185f96f. Read the comment docs.

@charlesbluca
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7823a18 into rapidsai:branch-21.08 Jul 12, 2021
@charlesbluca charlesbluca deleted the dask-series-groupby-return branch August 3, 2021 17:52
@vyasr vyasr added dask Dask issue and removed dask-cudf labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dask-cuDF Series groupby aggregation returns DataFrame
3 participants