Fix a crash in pack() when being handed tables with no columns. #8697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so changed the packed_columns struct so that even when returned empty, instead of metadata_ and gpu_data unique_ptrs being null, they will point to empty objects, making things a little safer.
nvdbaranec
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8697 +/- ##
===============================================
Coverage ? 10.63%
===============================================
Files ? 109
Lines ? 18659
Branches ? 0
===============================================
Hits ? 1985
Misses ? 16674
Partials ? 0 Continue to review full report at Codecov.
|
rgsl888prabhu
approved these changes
Jul 9, 2021
nvdbaranec
added
5 - DO NOT MERGE
harrism
approved these changes
Jul 13, 2021
harrism
added
the
5 - Ready to Merge
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2021
…vice data (#8759) A few changes in here to resolve some test failures using pack/unpack with DataFrame serialization: - We now use a `Buffer` in `frames` to represent the device data, so that Dask can correctly perform the necessary DtoD transfers when moving a packed columns object between devices - With #8697 merged, the results of packing an empty DataFrame will set the pointer to the host data to `NULL`; since Cython cannot make a memoryview from `NULL`, we now check for this condition before making the host data array - The serialized type is now included in the serialized header Authors: - Charles Blackmon-Luca (https://github.com/charlesbluca) Approvers: - https://github.com/brandon-b-miller - Michael Wang (https://github.com/isVoid) URL: #8759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes the behavior of pack() such that when returning empty data, the
metadata_andgpu_dataunique_ptrs are not null, but instead point to emptymetadataandrmm::device_bufferobjects, respectively. Very mild breakage of the interface.