Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JNI: Fix driver version assertion logic in testGetCudaRuntimeInfo [skip ci] #8701

Merged
merged 2 commits into from
Jul 9, 2021
Merged

JNI: Fix driver version assertion logic in testGetCudaRuntimeInfo [skip ci] #8701

merged 2 commits into from
Jul 9, 2021

Conversation

sperlingxx
Copy link
Contributor

A hot fix on the test for Java APIs which are used to get CUDA runtime information

@sperlingxx
hot fix for testGetCudaRuntimeInfo
8780674 
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
@sperlingxx sperlingxx requested a review from pxLi July 9, 2021 03:56
@sperlingxx sperlingxx requested a review from a team as a code owner July 9, 2021 03:56
@github-actions github-actions bot added the Java Affects Java cuDF API. label Jul 9, 2021
@sperlingxx sperlingxx added 4 - Needs cuDF (Java) Reviewer 3 - Ready for Review Ready for review by team ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround labels Jul 9, 2021
@pxLi pxLi changed the title JNI: Hotfix on testGetCudaRuntimeInfo JNI: Hotfix on testGetCudaRuntimeInfo [skip ci] Jul 9, 2021
@sperlingxx sperlingxx added the non-breaking Non-breaking change label Jul 9, 2021
@pxLi pxLi added the improvement Improvement / enhancement to an existing function label Jul 9, 2021
@sperlingxx sperlingxx added bug Something isn't working improvement Improvement / enhancement to an existing function and removed improvement Improvement / enhancement to an existing function labels Jul 9, 2021
@pxLi pxLi removed the improvement Improvement / enhancement to an existing function label Jul 9, 2021
@sperlingxx
hot fix for testGetCudaRuntimeInfo
19a1967 
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
@pxLi
Copy link
Member

pxLi commented Jul 9, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ecbec81 into rapidsai:branch-21.08 Jul 9, 2021
@jlowe
Copy link
Member

jlowe commented Jul 9, 2021

Couple of notes:

Hotfix shouldn't be used here, it's normally for tagging PRs that require a new release. Also a Java pipeline has been added as part of the CI process, so going forward we should not be marking Java PRs with [skip ci].

@jlowe jlowe removed the ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround label Jul 9, 2021
@jlowe jlowe changed the title JNI: Hotfix on testGetCudaRuntimeInfo [skip ci] JNI: Fix driver version assertion logic in testGetCudaRuntimeInfo [skip ci] Jul 9, 2021
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxLi pxLi pxLi approved these changes

@GaryShen2008 GaryShen2008 GaryShen2008 approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sperlingxx @pxLi @jlowe @GaryShen2008 @vyasr