Remove anonymous namespace from null_mask.cuh #8786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdbaranec
added
code quality
libcudf
nvdbaranec
added
the
improvement
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8786 +/- ##
===============================================
Coverage ? 10.51%
===============================================
Files ? 116
Lines ? 18957
Branches ? 0
===============================================
Hits ? 1993
Misses ? 16964
Partials ? 0 Continue to review full report at Codecov.
|
karthikeyann
approved these changes
Jul 20, 2021
mythrocks
approved these changes
Jul 20, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed a non-compliant anonymous namespace from
null_mask.cuh. The contents has been left in thecudf::detailnamespace.Resolves #8781