Replace is_same<>::value with is_same_v<>
#8852
Conversation
codereport
added
3 - Ready for Review
| int static constexpr encode_field_number_base(int field_number) noexcept | ||
| { | ||
| return (field_number * 8) + PB_TYPE_FIXED64; | ||
| } | ||
|
|
||
| template <typename T, | ||
| typename std::enable_if_t<!std::is_class<T>::value or | ||
| std::is_same<T, std::string>::value>* = nullptr> | ||
| typename std::enable_if_t<!std::is_class<T>::value or std::is_same_v<T, std::string>>* = |
There was a problem hiding this comment.
There might be value in a follow-up PR to convert these SFINAE checks into CUDF_ENABLE_IF().
There was a problem hiding this comment.
Unresolved conversation just to unhide the comment above 😃
There was a problem hiding this comment.
I wonder if we can config the CI style checker to detect such usage (of is_same<>::value) and raise a failure so we will never have to do this PR again.
There was a problem hiding this comment.
Once we get clang-tidy set up we could definitely automate this.
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8852 +/- ##
================================================
- Coverage 10.67% 10.59% -0.09%
================================================
Files 110 116 +6
Lines 18271 19035 +764
================================================
+ Hits 1951 2017 +66
- Misses 16320 17018 +698
Continue to review full report at Codecov.
|
|
rerun tests |
codereport
added
5 - Ready to Merge
|
@gpucibot merge |
Simple PR that ran a regex to replace
is_same<...>::valuewithis_same_v<...>