-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate dask-cudf CudfEngine to leverage ArrowDatasetEngine #8871
Merged
rapids-bot
merged 22 commits into
rapidsai:branch-21.10
from
rjzamora:migrate-parquet-backend
Aug 13, 2021
Merged
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
52a643c
save possible changes to enable multi-file parquet
rjzamora 3b3dadb
Merge remote-tracking branch 'upstream/branch-21.06' into multi-file-…
rjzamora 54644e1
align with latest upstream PR
rjzamora c5e660f
trigger format check
rjzamora e8cbc26
save some possible work aimed at uisng ParquetDatasetEngine
rjzamora 2ab6838
Merge remote-tracking branch 'upstream/branch-21.08' into multi-file-…
rjzamora 3079fff
Merge remote-tracking branch 'origin/multi-file-parquet' into migrate…
rjzamora d67f711
add test coverage
rjzamora a175daf
trigger format
rjzamora 14038e9
Merge branch 'multi-file-parquet' into migrate-parquet-backend
rjzamora 2407b89
Merge remote-tracking branch 'upstream/branch-21.08' into migrate-par…
rjzamora 648c3ce
remove commented code
rjzamora 494d585
remove commented code
rjzamora 2ccc046
Merge branch 'branch-21.10' into migrate-parquet-backend
rjzamora 07ed3c9
trigger formatting
rjzamora 5a918d8
try reformatting
rjzamora f6a4ad6
Merge remote-tracking branch 'upstream/branch-21.10' into migrate-par…
rjzamora 1473f36
Merge remote-tracking branch 'upstream/branch-21.10' into migrate-par…
rjzamora 3602394
test tweak
rjzamora 1db936a
Update python/dask_cudf/dask_cudf/io/tests/test_parquet.py
rjzamora 675c314
build cat column in a more efficient way
rjzamora d672ab5
make cat column creation more efficient and fix schema-missmatch test
rjzamora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot nicer with supported categorical column creation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that the new change here was a bit inefficent. We were creating a column with the partition-based category repeated in every element, and then converting it to a categorical column. It makes a bit more sense to repeat the index of the partition-based category in every element, and build the categorical column directly.