Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move structs_column_tests.cu to .cpp. #8902

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Move structs_column_tests.cu to .cpp. #8902

merged 1 commit into from
Jul 29, 2021

Conversation

mythrocks
Copy link
Contributor

Some minor fixes to the structs_column_tests.

  • Moved from .cu to .cpp (for make benefit glorious compile time).
  • Fixed compile warnings.
  • Added some missing asserts.
  • Fixed struct column comparison.

@mythrocks mythrocks requested a review from a team as a code owner July 29, 2021 18:14
@mythrocks mythrocks self-assigned this Jul 29, 2021
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Jul 29, 2021
@mythrocks mythrocks added 3 - Ready for Review Ready for review by team code quality improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 29, 2021
@mythrocks
Move structs_column_tests.cu to .cpp.
7d100a1 
* Fixed compile warnings.
* Added some missing asserts.
* Fixed struct<list> column comparison.
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #8902 (85041fc) into branch-21.10 (18f7c01) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 85041fc differs from pull request most recent head 7d100a1. Consider uploading reports for the commit 7d100a1 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8902      +/-   ##
================================================
- Coverage         10.67%   10.58%   -0.10%     
================================================
  Files               110      116       +6     
  Lines             18271    18657     +386     
================================================
+ Hits               1951     1974      +23     
- Misses            16320    16683     +363
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <ø> (ø)
python/cudf/cudf/core/frame.py 0.00% <ø> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f46f0...7d100a1. Read the comment docs.

@mythrocks
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 01b647a into rapidsai:branch-21.10 Jul 29, 2021
@mythrocks
Copy link
Contributor Author

Thanks for the reviews, all. I have merged this commit to branch-21.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@ttnghia ttnghia ttnghia approved these changes

@codereport codereport codereport approved these changes

Assignees

@mythrocks mythrocks

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mythrocks @robertmaynard @ttnghia @codereport