Move AST evaluator into a separate header #8930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8930 +/- ##
================================================
- Coverage 10.67% 10.61% -0.07%
================================================
Files 110 116 +6
Lines 18271 19001 +730
================================================
+ Hits 1951 2017 +66
- Misses 16320 16984 +664
Continue to review full report at Codecov.
|
ttnghia
approved these changes
Aug 3, 2021
Co-authored-by: Nghia Truong <ttnghia@users.noreply.github.com>
|
@gpucibot merge |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the logic for evaluating an AST from the logic for column computation using ASTs. This change ensures that conditional join code paths (and any other features that make use of libcudf AST evaluation in the future) do not depend on headers for the
compute_columnAPI. In addition to the improved conceptual clarity and separation of concerns, this significantly improves recompilation times when developing on either one of these features separately.Contributes to #8145.