Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Series.dt.is_quarter_start and Series.dt.is_quarter_end #9046

Merged
merged 16 commits into from
Aug 17, 2021
Merged

Added Series.dt.is_quarter_start and Series.dt.is_quarter_end #9046

merged 16 commits into from
Aug 17, 2021

Conversation

TravisHester
Copy link
Contributor

closes: #8679

Added Series.dt functions and tests for is_quarter_start and is_quarter_end.

@TravisHester TravisHester requested a review from a team as a code owner August 16, 2021 19:52
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 16, 2021
@TravisHester TravisHester added 3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change labels Aug 16, 2021
galipremsagar
galipremsagar requested changes Aug 16, 2021
View reviewed changes
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
galipremsagar
galipremsagar requested changes Aug 16, 2021
View reviewed changes
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar removed the 3 - Ready for Review Ready for review by team label Aug 16, 2021
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 16, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@codecov
Copy link

codecov bot commented Aug 16, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@abe57f8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 415a9ba differs from pull request most recent head 94df215. Consider uploading reports for the commit 94df215 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9046   +/-   ##
===============================================
  Coverage                ?   10.64%           
===============================================
  Files                   ?      114           
  Lines                   ?    19094           
  Branches                ?        0           
===============================================
  Hits                    ?     2033           
  Misses                  ?    17061           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe57f8...94df215. Read the comment docs.

marlenezw
marlenezw approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@marlenezw marlenezw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!

@rapids-bot rapids-bot bot merged commit 3402fec into rapidsai:branch-21.10 Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@marlenezw marlenezw marlenezw approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Series datetime is_quarter_end and is_quarter_start
3 participants
@TravisHester @galipremsagar @marlenezw