Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for single-digits in cudf::to_timestamps #9173

Merged
merged 8 commits into from
Sep 13, 2021
Merged

Add support for single-digits in cudf::to_timestamps #9173

merged 8 commits into from
Sep 13, 2021

Conversation

davidwendt
Copy link
Contributor

Closes #9082

This PR adds support to the cudf::to_timestamps API to allow single digit day and month in the input strings format.

Corresponding updates are also made to cudf::is_timestamps.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 2, 2021
@davidwendt davidwendt self-assigned this Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@c6ddd46). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d5c679e differs from pull request most recent head f82cd21. Consider uploading reports for the commit f82cd21 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9173   +/-   ##
===============================================
  Coverage                ?   10.81%           
===============================================
  Files                   ?      115           
  Lines                   ?    18775           
  Branches                ?        0           
===============================================
  Hits                    ?     2030           
  Misses                  ?    16745           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ddd46...f82cd21. Read the comment docs.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Sep 8, 2021
@davidwendt davidwendt marked this pull request as ready for review September 8, 2021 15:29
@davidwendt davidwendt requested a review from a team as a code owner September 8, 2021 15:29
devavret
devavret reviewed Sep 13, 2021
View reviewed changes
Copy link
Contributor

@devavret devavret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

cpp/src/strings/convert/convert_datetime.cu Outdated Show resolved Hide resolved
vyasr
vyasr reviewed Sep 13, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, otherwise LGTM.

cpp/src/strings/convert/convert_datetime.cu Outdated Show resolved Hide resolved
cpp/src/strings/convert/convert_datetime.cu Outdated Show resolved Hide resolved
cpp/src/strings/convert/convert_datetime.cu Show resolved Hide resolved
@vyasr vyasr self-requested a review September 13, 2021 18:12
@harrism
Copy link
Member

harrism commented Sep 13, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 04ae78b into rapidsai:branch-21.10 Sep 13, 2021
@davidwendt davidwendt deleted the fea-to-timestamp-single-digits branch September 13, 2021 21:33
@tgravescs tgravescs mentioned this pull request Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@devavret devavret devavret approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt

@cwharris cwharris Awaiting requested review from cwharris

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] to_datetime does not correctly convert single digit months and hours to datetime
4 participants
@davidwendt @harrism @vyasr @devavret