Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grouped_rolling test with STRUCT groupby keys. #9228

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

mythrocks
Copy link
Contributor

Fixes #8887.

#9024 added support for STRUCT groupby keys.
This commit adds a test for grouped_rolling_window() where the groupby keys are STRUCT.

This commit adds a test for `grouped_rolling_window()` where the
groupby keys are `STRUCT`.
@mythrocks mythrocks requested a review from a team as a code owner September 14, 2021 05:11
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 14, 2021
@mythrocks mythrocks self-assigned this Sep 14, 2021
@mythrocks mythrocks added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tests Unit testing for project labels Sep 14, 2021
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@eae76cf). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 095c88b differs from pull request most recent head 8e67306. Consider uploading reports for the commit 8e67306 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9228   +/-   ##
===============================================
  Coverage                ?   10.84%           
===============================================
  Files                   ?      115           
  Lines                   ?    19176           
  Branches                ?        0           
===============================================
  Hits                    ?     2080           
  Misses                  ?    17096           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae76cf...8e67306. Read the comment docs.

@mythrocks
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit bb9ed33 into rapidsai:branch-21.10 Sep 15, 2021
@mythrocks
Copy link
Contributor Author

Thanks for the reviews, chaps. I've merged this now.

@mythrocks mythrocks deleted the grouped-rolling-structs branch September 15, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] grouped rolling produces wrong answer for structs
3 participants