Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Java column leak in testParquetWriteMap #9271

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Fix Java column leak in testParquetWriteMap #9271

merged 1 commit into from
Sep 22, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Sep 22, 2021

Fixes a Java column vector leak in TableTest#testParquetWriteMap.

@jlowe jlowe added tests Unit testing for project Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer labels Sep 22, 2021
@jlowe jlowe self-assigned this Sep 22, 2021
@jlowe jlowe requested a review from a team as a code owner September 22, 2021 15:01
@jlowe jlowe added bug Something isn't working non-breaking Non-breaking change labels Sep 22, 2021
@jlowe jlowe mentioned this pull request Sep 22, 2021
Merged
@codecov
Copy link

codecov bot commented Sep 22, 2021 •
edited
Loading

Codecov Report

Merging #9271 (7b309ee) into branch-21.10 (3ee3ecf) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 7b309ee differs from pull request most recent head bfa2a64. Consider uploading reports for the commit bfa2a64 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #9271      +/-   ##
================================================
- Coverage         10.85%   10.85%   -0.01%     
================================================
  Files               115      116       +1     
  Lines             19158    19168      +10     
================================================
  Hits               2080     2080              
- Misses            17078    17088      +10
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/text.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba2cbd9...bfa2a64. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Sep 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b0c8bbb into rapidsai:branch-21.10 Sep 22, 2021
@jlowe jlowe deleted the fix-java-test-leak branch September 22, 2021 17:21
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@jlowe jlowe

Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlowe @revans2 @vyasr