Fix null count in statistics for parquet #9303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devavret
added
bug
devavret
requested review from
robertmaynard,
nvdbaranec,
isVoid and
charlesbluca
github-actions
bot
added
Python
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9303 +/- ##
================================================
- Coverage 10.79% 10.75% -0.04%
================================================
Files 116 116
Lines 18869 19482 +613
================================================
+ Hits 2036 2096 +60
- Misses 16833 17386 +553
Continue to review full report at Codecov.
|
kaatish
approved these changes
Oct 6, 2021
shwina
reviewed
Oct 6, 2021
Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>
shwina
approved these changes
Oct 6, 2021
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9221
The bug was in the method for calculating nulls
(num_rows - num_valid)which needednum_rowsto be summed intyped_statistics_chunkbecause it's not part of the untyped struct. This caused a problem because the serialtyped_statistics_chunk.reduce()had thenum_rowssummation but the parallelblock_reduce(typed_statistics_chunk)did not.As part of the fix,
num_rowsis removed entirely andnull_countis incremented in case of encountering nulls in the column.