Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CudaMemoryBuffer for cudaMalloc memory using RMM cuda_memory_resource #9311

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Add CudaMemoryBuffer for cudaMalloc memory using RMM cuda_memory_resource #9311

merged 3 commits into from
Sep 27, 2021

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Sep 25, 2021

Fixes #9270

@rongou rongou added feature request New feature or request 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Sep 25, 2021
@rongou rongou self-assigned this Sep 25, 2021
@rongou rongou requested a review from a team as a code owner September 25, 2021 00:07
@codecov
Copy link

codecov bot commented Sep 25, 2021 •
edited
Loading

Codecov Report

Merging #9311 (ea39276) into branch-21.12 (ab4bfaa) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9311      +/-   ##
================================================
+ Coverage         10.79%   10.83%   +0.04%     
================================================
  Files               116      116              
  Lines             18869    19258     +389     
================================================
+ Hits               2036     2087      +51     
- Misses            16833    17171     +338
Impacted Files Coverage Δ
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908c130...ea39276. Read the comment docs.

@rongou
Copy link
Contributor Author

rongou commented Sep 27, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fd77ca6 into rapidsai:branch-21.12 Sep 27, 2021
@abellina abellina changed the title add a new memory buffer that directly allocates with cudaMalloc Add CudaMemoryBuffer for cudaMalloc memory using RMM cuda_memory_resource Sep 30, 2021
@rongou rongou deleted the jni-alloc-cuda branch November 23, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@abellina abellina abellina approved these changes

@revans2 revans2 Awaiting requested review from revans2

Assignees

@rongou rongou

Labels
3 - Ready for Review Ready for review by team feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] [Java] Add a way to allocate via cudaMalloc for device memory buffers
3 participants
@rongou @jlowe @abellina