Fix #9247: Prevent Numba Performance Warnings in cuDF #9320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numba 0.54 introduces performance warnings whenever a kernel is launched with low occupancy. Certain operations in cuDF can indirectly cause this warning to be emitted, for example `DataFrame.iloc` (which one would not expect to be particularly efficient anyway). This message could be disconcerting for users and appear in a lot of workflows; therefore, this commit configures Numba at cuDF import time to suppress the low occupancy warning. Fixes rapidsai#9247.
galipremsagar
approved these changes
Sep 28, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9320 +/- ##
================================================
- Coverage 10.80% 10.79% -0.01%
================================================
Files 116 116
Lines 19321 19326 +5
================================================
Hits 2087 2087
- Misses 17234 17239 +5
Continue to review full report at Codecov.
|
brandon-b-miller
approved these changes
Sep 28, 2021
|
rerun tests |
|
I think targeting 21.10 is a good idea, given that this will often be a confusing warning that the user can't do anything about (for built in cudf operations). Thanks for opening it. |
|
rerun tests |
ajschmidt8
added
improvement
raydouglass
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numba 0.54 introduces performance warnings whenever a kernel is launched with low occupancy. Certain operations in cuDF can indirectly cause this warning to be emitted, for example
DataFrame.iloc(which one would not expect to be particularly efficient anyway). This message could be disconcerting for users and appear in a lot of workflows; therefore, this commit configures Numba 0.54 at cuDF import time to suppress the low occupancy warning.Fixes #9247.
There has been some discussion about whether this needs to be a hotfix, so I'm opening this PR initially targeted at 21.10 accordingly - cc @quasiben @shwina @JohnZed.