Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cython compilation warnings. #9327

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Sep 28, 2021

This PR fixes three small issues relating to uninitialized variables in Cython code. This removes warnings from the build log and fixes potential bugs.

  • Parquet code had a boolean variable is_range_index that was not initialized if json_str != "".
  • Reduction scan type wasn't correctly initialized (if True: / elif False: pattern)
  • Undesired comparison of a signed int and an unsigned value in a utility function.

@bdice bdice requested a review from a team as a code owner September 28, 2021 19:53
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 28, 2021
@bdice bdice added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change tech debt labels Sep 28, 2021
@bdice bdice self-assigned this Sep 28, 2021
@bdice bdice added 2 - In Progress Currently a work in progress and removed 3 - Ready for Review Ready for review by team labels Sep 28, 2021
@bdice bdice added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function and removed 2 - In Progress Currently a work in progress labels Sep 28, 2021
@bdice
Copy link
Contributor Author

bdice commented Sep 28, 2021

rerun tests

@bdice
Copy link
Contributor Author

bdice commented Sep 29, 2021

rerun tests

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #9327 (41793eb) into branch-21.12 (ab4bfaa) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 41793eb differs from pull request most recent head 4f9edfa. Consider uploading reports for the commit 4f9edfa to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9327      +/-   ##
================================================
+ Coverage         10.79%   10.81%   +0.02%     
================================================
  Files               116      116              
  Lines             18869    18873       +4     
================================================
+ Hits               2036     2042       +6     
+ Misses            16833    16831       -2     
Impacted Files Coverage Δ
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/backends.py 82.31% <0.00%> (+3.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6484e2a...4f9edfa. Read the comment docs.

@shwina
Copy link
Contributor

shwina commented Sep 29, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8935f6d into rapidsai:branch-21.12 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants