Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libcudf compile warnings on debug 11.4 build #9360

Merged

Conversation

davidwendt
Copy link
Contributor

This fixes some compile warnings recently added in #9299 and #9278. These warnings are turned into errors on a libcudf Debug build.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Oct 4, 2021
@davidwendt davidwendt self-assigned this Oct 4, 2021
@davidwendt davidwendt requested a review from a team as a code owner October 4, 2021 16:06
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #9360 (470d328) into branch-21.12 (ab4bfaa) will decrease coverage by 0.03%.
The diff coverage is 1.82%.

❗ Current head 470d328 differs from pull request most recent head 53fb18d. Consider uploading reports for the commit 53fb18d to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9360      +/-   ##
================================================
- Coverage         10.79%   10.75%   -0.04%     
================================================
  Files               116      116              
  Lines             18869    19076     +207     
================================================
+ Hits               2036     2051      +15     
- Misses            16833    17025     +192     
Impacted Files Coverage Δ
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/timedelta.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d68e626...53fb18d. Read the comment docs.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vyasr
Copy link
Contributor

vyasr commented Oct 5, 2021

rerun tests

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6593339 into rapidsai:branch-21.12 Oct 5, 2021
@davidwendt davidwendt deleted the fix-114-compile-warnings branch October 5, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants