Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct issues in the build dir cudf-config.cmake #9386

Conversation

robertmaynard
Copy link
Contributor

Resolves two outstanding issues with the build directory cudf-config.cmake.

  • The arrow_static wasn't being marked as a GLOBAL import target and therefore not seen by consumers
  • The logic to mark the libcudacxx include directory as non-system was incorrect and only worked for install directory versions of the cudf-config. This corrects that oversight.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team CMake CMake build issue labels Oct 6, 2021
@robertmaynard robertmaynard requested a review from a team as a code owner October 6, 2021 15:32
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 6, 2021
@robertmaynard robertmaynard added the non-breaking Non-breaking change label Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #9386 (e50b52a) into branch-21.12 (ab4bfaa) will decrease coverage by 0.03%.
The diff coverage is 1.97%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9386      +/-   ##
================================================
- Coverage         10.79%   10.75%   -0.04%     
================================================
  Files               116      116              
  Lines             18869    19487     +618     
================================================
+ Hits               2036     2096      +60     
- Misses            16833    17391     +558     
Impacted Files Coverage Δ
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/timedelta.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d68e626...e50b52a. Read the comment docs.

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@robertmaynard robertmaynard requested a review from a team October 8, 2021 18:02
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@rapids-bot rapids-bot bot merged commit 9b17f08 into rapidsai:branch-21.12 Oct 8, 2021
@robertmaynard robertmaynard deleted the bug/correct_issues_in_cudf-config branch October 12, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants