Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Comparing Uniform Window Results in Var/std Tests #9416

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Oct 11, 2021

Close #9404

The issue in 9404 results from that pandas computes different rolling std results on x86 compared to aarch64 on a uniform window. In this specific test case, the window is

(Pdb) pdf['1'][574:576]
574    2.064967e+153
575    2.064967e+153
Name: 1, dtype: float64

On aarch64, pandas computes

(Pdb) mask = np.isclose(expect['1'].fillna(0), got['1'].fillna(0).to_pandas())
(Pdb) expect['1'][~mask]
575    1.149735e+145

On x86, pandas computes

(Pdb) expect['1'][575]
0.0

Since the results computed on uniform windows by pandas is not reliable, this PR drops these rows before comparing the results.

@isVoid isVoid requested a review from a team as a code owner October 11, 2021 22:24
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 11, 2021
@isVoid isVoid linked an issue Oct 11, 2021 that may be closed by this pull request
@isVoid isVoid added non-breaking Non-breaking change bug Something isn't working labels Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #9416 (d105746) into branch-21.12 (442009b) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head d105746 differs from pull request most recent head 6830ace. Consider uploading reports for the commit 6830ace to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9416      +/-   ##
================================================
- Coverage         10.79%   10.74%   -0.06%     
================================================
  Files               116      116              
  Lines             19326    19506     +180     
================================================
+ Hits               2087     2096       +9     
- Misses            17239    17410     +171     
Impacted Files Coverage Δ
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/strings/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 442009b...6830ace. Read the comment docs.

@isVoid isVoid changed the base branch from branch-21.10 to branch-21.12 October 12, 2021 15:59
@shwina
Copy link
Contributor

shwina commented Oct 12, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fa571a7 into rapidsai:branch-21.12 Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Rolling std/var test fails on aarch64
4 participants