Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memcheck error in gtest SegmentedGatherTest/GatherSliced #9442

Merged

Conversation

davidwendt
Copy link
Contributor

Recent run of cuda-memcheck on gtests/COPYING_TEST uncovered an error in the segmented_gather_list_tests.cpp logic for GatherSliced. The memcheck reported a read error on the gather-map which was created with a temporary lists column that was freed before passing it to the cudf::lists::detail::segmented_gather function. Fixing the testcase fixed the memcheck error.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Oct 14, 2021
@davidwendt davidwendt self-assigned this Oct 14, 2021
@davidwendt davidwendt requested a review from a team as a code owner October 14, 2021 19:40
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #9442 (faea7a6) into branch-21.12 (ab4bfaa) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head faea7a6 differs from pull request most recent head 9fe27a7. Consider uploading reports for the commit 9fe27a7 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9442      +/-   ##
================================================
- Coverage         10.79%   10.77%   -0.02%     
================================================
  Files               116      117       +1     
  Lines             18869    19046     +177     
================================================
+ Hits               2036     2052      +16     
- Misses            16833    16994     +161     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/strings/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/reshape.py 0.00% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa2738...9fe27a7. Read the comment docs.

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 74763ba into rapidsai:branch-21.12 Oct 18, 2021
@davidwendt davidwendt deleted the memcheck-segmented-gather branch October 18, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants