Small clean up to simplify column selection code in ORC reader #9444
Conversation
vuule
added
cuIO
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9444 +/- ##
================================================
+ Coverage 10.79% 10.82% +0.03%
================================================
Files 116 117 +1
Lines 18869 19043 +174
================================================
+ Hits 2036 2061 +25
- Misses 16833 16982 +149
Continue to review full report at Codecov.
|
|
rerun tests |
| */ | ||
| void add_column(std::vector<std::vector<orc_column_meta>>& selection, | ||
| std::vector<SchemaType> const& types, | ||
| const size_t level, | ||
| const uint32_t id, | ||
| bool& has_timestamp_column, | ||
| bool& has_nested_column) | ||
| bool& has_timestamp_column) |
There was a problem hiding this comment.
In case you ever add more flags like this it might be a good place to use a set of bit flags instead of multiple bools. Not actionable now, just a thought.
There was a problem hiding this comment.
I would prefer to return pair/tuple of bools instead of having output argument.
There was a problem hiding this comment.
I'm hoping to remove the remaining flag at some point.
|
rerun tests |
|
@gpucibot merge |
Remove
has_nested_columnfrom column selection and theimplclass.Deduce the existence of nested columns from the depth of the schema instead.