Update mypy pre-commit hook to 0.910. #9448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed for Python 3).
bdice
added
3 - Ready for Review
|
rerun tests |
|
Closing. See #9450 (comment). |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
…9490) Some changes in #9412 and #9433 may lead to conflicts in VSCode / rapids-compose behavior for many developers. I am closing my PRs #9448 and #9450 for the same reason. See #9450 (comment) for details. This PR reverts the problematic parts of #9412 and #9433, and makes the pre-commit configuration and the conda environment pinnings consistent. Tagging @vyasr @galipremsagar @ajschmidt8 for awareness. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Vyas Ramasubramani (https://github.com/vyasr) URL: #9490
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2021
I noticed while working on #9448 that we `import six` but it doesn't appear to be a dependency of cuDF. Since that package is meant for Python 2 compatibility and we do not support Python 2, I think it can be removed. `six` is probably being installed as a transitive dependency of some dependency of cuDF, if I were to guess, otherwise I'd think tests would fail. Note: the `queryutils.py` module containing these lines may be somewhat outdated. The module [is not covered by tests from 21.08](https://app.codecov.io/gh/rapidsai/cudf/blob/branch-21.08/python/cudf/cudf/utils/queryutils.py) through 21.12, but [was covered by tests in 21.06](https://app.codecov.io/gh/rapidsai/cudf/blob/branch-21.06/python/cudf/cudf/utils/queryutils.py). It is currently only used in a couple places, which may deserve some cleanup: https://github.com/rapidsai/cudf/search?q=queryutils Authors: - Bradley Dice (https://github.com/bdice) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Sheilah Kirui (https://github.com/skirui-source) URL: #9495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #9300 and #9433, this PR updates the mypy pre-commit hook to a modern version, 0.910. The 0.900 release of mypy made some breaking changes, and required nontrivial modifications to the code. The changes in newer versions of mypy had previously caused issues with our static checks over the codebase, which I documented in #9300.
See commit log for details on the changes that were needed.