Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Update docstring of DataFrame.merge [skip ci] #9572

Merged
merged 3 commits into from
Nov 1, 2021
Merged

[REVIEW] Update docstring of DataFrame.merge [skip ci] #9572

merged 3 commits into from
Nov 1, 2021

Conversation

galipremsagar
Copy link
Contributor

Resolves: #9460

This PR adds descriptions for already supported merge options.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team doc Documentation 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Nov 1, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner November 1, 2021 13:11
@galipremsagar galipremsagar self-assigned this Nov 1, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 1, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Nov 1, 2021
@galipremsagar
Copy link
Contributor Author

rerun tests

vyasr
vyasr approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one suggestion to improve the wording, but I'm approving so you can merge whenever you've addressed that as you see fit.

python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
@galipremsagar @vyasr
Update python/cudf/cudf/core/dataframe.py
9c158b8 
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@galipremsagar
Copy link
Contributor Author

skipping ci run as this is only a docstring update and CI seems to be failing on unrelated/intermittent issues.

@galipremsagar galipremsagar changed the title [REVIEW] Update docstring of DataFrame.merge [REVIEW][skip-ci] Update docstring of DataFrame.merge Nov 1, 2021
@galipremsagar galipremsagar changed the title [REVIEW][skip-ci] Update docstring of DataFrame.merge [REVIEW][skip gpuci] Update docstring of DataFrame.merge Nov 1, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@galipremsagar galipremsagar changed the title [REVIEW][skip gpuci] Update docstring of DataFrame.merge [REVIEW] Update docstring of DataFrame.merge [skip gpuci] Nov 1, 2021
@galipremsagar galipremsagar changed the title [REVIEW] Update docstring of DataFrame.merge [skip gpuci] [REVIEW] Update docstring of DataFrame.merge [skip ci] Nov 1, 2021
@galipremsagar
Copy link
Contributor Author

rerun tests

@rapids-bot rapids-bot bot merged commit e632f97 into rapidsai:branch-21.12 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@vyasr vyasr vyasr approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] cudf.DataFrame.merge how options incomplete
3 participants
@galipremsagar @thomcom @vyasr