Use std::size_t when computing join output size #9626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
added
bug
ttnghia
approved these changes
Nov 8, 2021
ttnghia
reviewed
Nov 8, 2021
Comment on lines
+128
to
+132
| std::size_t size; | ||
| if constexpr (JoinKind == join_kind::LEFT_JOIN) { | ||
| size = static_cast<size_type>( | ||
| hash_table.pair_count_outer(iter, iter + probe_table_num_rows, equality, stream.value())); | ||
| size = hash_table.pair_count_outer(iter, iter + probe_table_num_rows, equality, stream.value()); | ||
| } else { | ||
| size = static_cast<size_type>( | ||
| hash_table.pair_count(iter, iter + probe_table_num_rows, equality, stream.value())); | ||
| size = hash_table.pair_count(iter, iter + probe_table_num_rows, equality, stream.value()); |
There was a problem hiding this comment.
Nit: Indeed you can just do this:
if constexpr (JoinKind == join_kind::LEFT_JOIN) {
return hash_table.pair_count_outer(iter, iter + probe_table_num_rows, equality, stream.value());
} else {
return hash_table.pair_count(iter, iter + probe_table_num_rows, equality, stream.value());
}
|
Rerun tests. |
abellina
approved these changes
Nov 8, 2021
mythrocks
approved these changes
Nov 8, 2021
hyperbolic2346
approved these changes
Nov 8, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9626 +/- ##
================================================
- Coverage 10.79% 10.66% -0.13%
================================================
Files 116 117 +1
Lines 18869 19825 +956
================================================
+ Hits 2036 2115 +79
- Misses 16833 17710 +877
Continue to review full report at Codecov.
|
nvdbaranec
approved these changes
Nov 8, 2021
|
Oh, it's my mistake when refactoring hash join. Thanks for fixing it! |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9625. Updates
hash_join::compute_join_output_sizeto use std::size_t instead of cudf::size_type as the intermediate type to hold the computed output size.