Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Pin max dask & distributed versions #9734

Merged
merged 4 commits into from
Nov 22, 2021
Merged

[REVIEW] Pin max dask & distributed versions #9734

merged 4 commits into from
Nov 22, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR introduces max version pinnings for dask & distributed to 2021.11.2

@galipremsagar galipremsagar self-assigned this Nov 19, 2021
@galipremsagar galipremsagar requested review from a team as code owners November 19, 2021 16:23
@galipremsagar galipremsagar requested review from cwharris, skirui-source, quasiben and jakirkham and removed request for a team November 19, 2021 16:23
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Nov 19, 2021
This was referenced Nov 19, 2021
Merged
Merged
Merged
Merged
Merged
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Nov 19, 2021
bdice
bdice requested changes Nov 19, 2021
View reviewed changes
conda/recipes/dask-cudf/meta.yaml Outdated Show resolved Hide resolved
@galipremsagar @bdice
Update conda/recipes/dask-cudf/meta.yaml
b1cafad 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
galipremsagar
galipremsagar commented Nov 19, 2021
View reviewed changes
conda/recipes/dask-cudf/meta.yaml Outdated
- cudatoolkit {{ cuda_version }}
run:
- python
- cudf {{ version }}
- dask>=2021.09.1
- dask>=2021.09.1,<=2021.11.2
- distributed>=2021.09.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- distributed>=2021.09.1
- distributed>=2021.09.1,<=2021.11.2

jakirkham
jakirkham reviewed Nov 19, 2021
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion offline suggesting we constrain dask & distributed with >=2021.11.1,<=2021.11.2

conda/environments/cudf_dev_cuda11.0.yml Outdated Show resolved Hide resolved
conda/environments/cudf_dev_cuda11.2.yml Outdated Show resolved Hide resolved
conda/environments/cudf_dev_cuda11.5.yml Outdated Show resolved Hide resolved
conda/recipes/custreamz/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/dask-cudf/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/dask-cudf/meta.yaml Outdated Show resolved Hide resolved
python/custreamz/dev_requirements.txt Outdated Show resolved Hide resolved
python/dask_cudf/dev_requirements.txt Outdated Show resolved Hide resolved
python/dask_cudf/setup.py Outdated Show resolved Hide resolved
@galipremsagar @jakirkham
Apply suggestions from code review
e69cdd8 
Co-authored-by: jakirkham <jakirkham@gmail.com>
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #9734 (2633873) into branch-21.12 (cb894e0) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2633873 differs from pull request most recent head e69cdd8. Consider uploading reports for the commit e69cdd8 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           branch-21.12    #9734   +/-   ##
=============================================
  Coverage         10.61%   10.61%           
=============================================
  Files               118      118           
  Lines             20075    20072    -3     
=============================================
  Hits               2130     2130           
+ Misses            17945    17942    -3
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb894e0...e69cdd8. Read the comment docs.

rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Nov 21, 2021
@galipremsagar
Pin max dask and distributed to 2012.11.2 (#4390)
edb77e9 
Changes to be in-line with: rapidsai/cudf#9734

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #4390
pentschev
pentschev approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar !

rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Nov 22, 2021
@galipremsagar
Pin max dask & distributed to 2021.11.2 (#1958)
5f5ccc3 
Changes to be in-line with: rapidsai/cudf#9734

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: #1958
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Nov 22, 2021
@galipremsagar
Pin max dask & distributed versions (#794)
a9d2554 
Changes to be in-line with rapidsai/cudf#9734

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #794
@ajschmidt8 ajschmidt8 merged commit 8e2ac44 into rapidsai:branch-21.12 Nov 22, 2021
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Nov 22, 2021
@galipremsagar
Pin max dask & distributed (#388)
8ef8166 
Changes to be in-line with: rapidsai/cudf#9734

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #388
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@galipremsagar
Pin max dask and distributed to 2012.11.2 (rapidsai#4390)
a54a5d4 
Changes to be in-line with: rapidsai/cudf#9734

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#4390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@bdice bdice bdice approved these changes

@pentschev pentschev pentschev approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@quasiben quasiben Awaiting requested review from quasiben

Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@galipremsagar @jakirkham @bdice @pentschev @ajschmidt8