Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JNI: Push back decimal utils from spark-rapids #9907

Merged
merged 8 commits into from
Feb 22, 2022
Merged

JNI: Push back decimal utils from spark-rapids #9907

merged 8 commits into from
Feb 22, 2022

Conversation

sperlingxx
Copy link
Contributor

Current PR is to push back cuDF-related decimal utilities from spark-rapids (for NVIDIA/spark-rapids#3793).

These utils were manually verified through spark-rapids integration tests.

@sperlingxx
migrate DecimalUtils from spark-rapids
163987a 
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
@sperlingxx sperlingxx requested a review from a team as a code owner December 15, 2021 11:47
@github-actions github-actions bot added the Java Affects Java cuDF API. label Dec 15, 2021
@sperlingxx sperlingxx added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change tech debt improvement Improvement / enhancement to an existing function and removed tech debt labels Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021 •
edited
Loading

Codecov Report

Merging #9907 (d206e1b) into branch-22.04 (7f2a16f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-22.04    #9907   +/-   ##
=============================================
  Coverage         10.67%   10.67%           
=============================================
  Files               122      122           
  Lines             20873    20873           
=============================================
  Hits               2228     2228           
  Misses            18645    18645

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2a16f...d206e1b. Read the comment docs.

@sperlingxx
Copy link
Contributor Author

rerun tests

@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@sperlingxx sperlingxx changed the base branch from branch-22.02 to branch-22.04 February 14, 2022 03:22
@sperlingxx sperlingxx mentioned this pull request Feb 18, 2022
Merged
@ttnghia
Copy link
Contributor

ttnghia commented Feb 18, 2022

Hey, this is forgotten.

ttnghia
ttnghia approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve but approval is not counted because I'm not java-codeowner 😃

@sperlingxx
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 36e8825 into rapidsai:branch-22.04 Feb 22, 2022
@sperlingxx sperlingxx deleted the decimal_utils branch February 22, 2022 09:29
sperlingxx added a commit to NVIDIA/spark-rapids that referenced this pull request Feb 23, 2022
@sperlingxx
Push decimal workarounds to cuDF (#4822)
55e0593 
Signed-off-by: sperlingxx <lovedreamf@gmail.com>

Closes #3793

Pushes cuDF-related decimal utilities down to cuDF. This PR is relied on cuDF changes: rapidsai/cudf#9809, rapidsai/cudf#9907 and rapidsai/cudf#10316.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@ttnghia ttnghia ttnghia approved these changes

@revans2 revans2 Awaiting requested review from revans2

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sperlingxx @ttnghia @jlowe