Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java bindings for mixed left, inner, and full joins #9941

Merged
merged 7 commits into from
Jan 19, 2022
Merged

Java bindings for mixed left, inner, and full joins #9941

merged 7 commits into from
Jan 19, 2022

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Dec 21, 2021

Depends on #9917. Adds Java bindings for the libcudf mixed join APIs. A new MixedJoinSize class was added to track the size information returned for mixed joins.

@jlowe jlowe added feature request New feature or request 2 - In Progress Currently a work in progress Java Affects Java cuDF API. non-breaking Non-breaking change labels Dec 21, 2021
@jlowe jlowe self-assigned this Dec 21, 2021
@jlowe jlowe requested a review from a team as a code owner December 21, 2021 16:56
revans2
revans2 approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Some of the naming I am not thrilled with, like leftKeys and rightKeys vs leftCondition and rightCondition with condition. But it is clear enough that it only took a second to know what they were for when reading the code. So I think it is good.

@jlowe jlowe mentioned this pull request Jan 7, 2022
Merged
@codecov
Copy link

codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #9941 (1e20a14) into branch-22.02 (967a333) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 1e20a14 differs from pull request most recent head 0652f8f. Consider uploading reports for the commit 0652f8f to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9941      +/-   ##
================================================
- Coverage         10.49%   10.41%   -0.08%     
================================================
  Files               119      119              
  Lines             20305    20541     +236     
================================================
+ Hits               2130     2139       +9     
- Misses            18175    18402     +227
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.66% <0.00%> (-0.25%) ⬇️
python/dask_cudf/dask_cudf/core.py 70.85% <0.00%> (-0.17%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/scalar.py 0.00% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a16ae...0652f8f. Read the comment docs.

@jlowe jlowe mentioned this pull request Jan 13, 2022
Merged
@jlowe jlowe added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress labels Jan 18, 2022
@jlowe
Copy link
Member Author

jlowe commented Jan 18, 2022

rerun tests

@ttnghia
Copy link
Contributor

ttnghia commented Jan 19, 2022

Rerun tests.

@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e49084e into rapidsai:branch-22.02 Jan 19, 2022
rapids-bot bot pushed a commit that referenced this pull request Jan 25, 2022
@jlowe
Java bindings for mixed semi and anti joins (#10040)
52a61b7 
This depends on #9941 and #10037.  Adds Java bindings for mixed left semi join and mixed left anti join.

Authors:
  - Jason Lowe (https://github.com/jlowe)

Approvers:
  - Alessandro Bellina (https://github.com/abellina)
  - Thomas Graves (https://github.com/tgravescs)
  - Jim Brennan (https://github.com/jbrennan333)

URL: #10040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@jlowe jlowe

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlowe @ttnghia @galipremsagar @revans2