Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Additional Naive Bayes improvements #1891

Merged
merged 34 commits into from
Mar 23, 2020
Merged

[REVIEW] Additional Naive Bayes improvements #1891

merged 34 commits into from
Mar 23, 2020

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 17, 2020

This PR contains improvements to Naive Bayes speed and memory usage. This should be merged after dask/distributed#3584.

@cjnolet cjnolet requested a review from a team as a code owner March 17, 2020 23:44
@cjnolet cjnolet added 2 - In Progress Currenty a work in progress Cython / Python Cython or Python issue Dask / cuml.dask Issue/PR related to Python level dask or cuml.dask features. Multi-GPU Issues & PRs related to multi-GPU functionality labels Mar 17, 2020
@cjnolet cjnolet changed the title [WIP] Additional Naive Bayes improvements [REVIEW] Additional Naive Bayes improvements Mar 19, 2020
@cjnolet
Copy link
Member Author

cjnolet commented Mar 20, 2020

rerun tests

dantegd
dantegd approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI, and with the github issue raised in Dask, lgtm

@cjnolet
Copy link
Member Author

cjnolet commented Mar 20, 2020

rerun tests

@cjnolet cjnolet reopened this Mar 20, 2020
@cjnolet
Copy link
Member Author

cjnolet commented Mar 20, 2020

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Mar 20, 2020

rerun tests

@cjnolet cjnolet mentioned this pull request Mar 21, 2020
Merged
@cjnolet
Copy link
Member Author

cjnolet commented Mar 21, 2020

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Mar 22, 2020

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Mar 23, 2020

rerun tests

dantegd
dantegd approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the new changes

@dantegd
Copy link
Member

dantegd commented Mar 23, 2020

@cjnolet could you add the details of your changes to issue #1903 ?

@cjnolet cjnolet merged commit 7a02e54 into rapidsai:branch-0.13 Mar 23, 2020
@JohnZed JohnZed mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue Dask / cuml.dask Issue/PR related to Python level dask or cuml.dask features. Multi-GPU Issues & PRs related to multi-GPU functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjnolet @dantegd