-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Adding Cython to Code Coverage #3111
Merged
JohnZed
merged 5 commits into
rapidsai:branch-0.17
from
mdemoret-nv:fea-add-cython-to-codecov
Nov 6, 2020
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fdbcdfd
Adding ability to build with --linetrace=1 to support cython codecov
mdemoret-nv 50d40de
Adding PR to CHANGELOG
mdemoret-nv fce62cb
Style cleanup
mdemoret-nv 5e45bd7
Converting BUILD_PYTHON_ARGS to be a argument in build.sh
mdemoret-nv d95d80e
Merge remote-tracking branch 'upstream/branch-0.17' into fea-add-cyth…
mdemoret-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
[run] | ||
include = cuml/* | ||
omit = cuml/test/* | ||
plugins = Cython.Coverage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,4 +23,5 @@ inplace = True | |
binding = True | ||
language_level = 3 | ||
profile = False | ||
linetrace = False | ||
embedsignature = True |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be a command-line flag instead, like "--python-args"? Seems like that would be more consistent with the other inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try and convert it to a command line argument, but it will be a little riskier since it will be a little different than all of our current command line args. This would be the only one that accepts an argument value. All of the current options (
-g
,-n
,--singlegpu
, etc.) are boolean flags which is much easier to parse. I'm just a little concerned that we may miss some edge cases when parsing arbitrary arguments since this runs on several platforms.I'll give it a shot and see if there are any other
build.sh
scripts in rapids that take arbitrary valuesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up sticking with boolean flags and added a new
--codecov
option tobuild.sh
. This doesn't add any risk from parsing argument values and is generic enough to possibly include C++ code coverage one day (if we can figure out how to do it).I'm open to different argument name. Let me know if you have a better selection. Link to the help section: https://github.com/rapidsai/cuml/pull/3111/files#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823R46-R47