Update to flake8 7.1.1.

[bdice]

We need to update flake8 to fix a false-positive that appears with older flake8 versions on Python 3.12.

[jameslamb]

Support updating flake8, but I left one comment... I'm concerned about the change to BaseStackedLine.

[jameslamb]

This one doesn't look right to me. I don't see self.colors getting set in __init__().

cuxfilter/python/cuxfilter/charts/core/non_aggregate/core_stacked_line.py

Line 59 in 53537fe

def __init__(

And I found at least one place that appears to rely on this attribute being defined on an instance:

cuxfilter/python/cuxfilter/charts/datashader/plots.py

Line 384 in 53537fe

class StackedLines(BaseStackedLine):

cuxfilter/python/cuxfilter/charts/datashader/plots.py

Line 394 in 53537fe

colors = colors or self.colors

What was the the flake8 error that this change addresses? Maybe there's another way we could address it, like a more specific type hint in the initialization of colors.

[bdice]

colors is also defined as a property here:

cuxfilter/python/cuxfilter/charts/core/non_aggregate/core_stacked_line.py

Lines 52 to 56 in f9a617d

	@property
	def colors(self):
	if self.colors_set:
	return list(self._colors_input)
	return self.default_colors * len(self.y)

flake8 was mad that this object had both an attribute and a property with the same name, and it seemed to me that the property was the correct choice to keep. What do you think?

[jameslamb]

ahhhh my git grep -E '\.colors' wouldn't have caught it being defined with @property, should have thought of that!

Ok then yeah this is totally fine, and I agree with preferring the @property one. Thanks for explaining that.

[bdice]

cc: @AjayThorve for awareness

[AjayThorve]

thanks, this seems correct, and yes property is the right one to keep

[AjayThorve]

LGTM, thanks!

[AjayThorve]

thanks, this seems correct, and yes property is the right one to keep

[AjayThorve]

seems like the CI is failing due to a new dependency introduced to bokeh_sampledata. Would need to add it to dependencies.yaml to fix the issue for notebooks and docs.

pushing the changes to this PR

[bdice]

/merge