Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding profiling to dask shuffle #625

Merged
merged 2 commits into from
May 26, 2021

Conversation

arunraman
Copy link
Contributor

Adding benchmark profile for dask shuffle.

@arunraman arunraman requested a review from a team as a code owner May 25, 2021 18:13
@github-actions github-actions bot added the python python code needed label May 25, 2021
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@madsbk madsbk added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 25, 2021
@ajschmidt8
Copy link
Member

add to allowlist

@jakirkham
Copy link
Member

The CI failures here should be resolved by PR ( #623 ) and PR ( rapidsai/cudf#8342 )

@arunraman
Copy link
Contributor Author

The CI failures here should be resolved by PR ( #623 ) and PR ( rapidsai/cudf#8342 )

Thanks, do I need to re-trigger the test?

@jakirkham
Copy link
Member

No we can do that. We just have to wait for those PRs to be merged

@madsbk
Copy link
Member

madsbk commented May 26, 2021

Thanks @arunraman, good idea including profiling of the explicit-comms execution!

Hope you don't mind, I took the liberty to move the profiling to include both the regular and the explicit-comms execution.

@quasiben
Copy link
Member

rerun tests

@jakirkham
Copy link
Member

Still waiting on PR ( #623 ) before CI is fixed

@pentschev
Copy link
Member

rerun tests

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 81bbc6f into rapidsai:branch-21.06 May 26, 2021
@madsbk
Copy link
Member

madsbk commented May 27, 2021

BTW @arunraman, Dask's performance profile might not include the communication within the explict-comms tasks. @jakirkham do you know what the performance profile capture exactly?

@quasiben
Copy link
Member

Performance profile will capture:

  • Task Stream
  • Worker Profile Compute
  • Worker Profile Admin
  • Scheduler Profile Admin
  • Communication Bandwidth by worker
  • Communication Bandwidth by type

@madsbk
Copy link
Member

madsbk commented May 31, 2021

@quasiben, what about manually created endpoints:

ep = await distributed.comm.connect(address)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants