-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate azure/notebooks/Azure-MNMG-XGBoost.ipynb
to deployment docs
#253
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @skirui-source. Made a few commands in ReviewNB. It also looks like CI is failing due to some broken links. Could you fix those up?
Seeing the error below:
|
Resolved the ForestInference load issue, all cells now working correctly! but will need to clear all outputs |
@jacobtomlinson this PR has been ready for another review/merge. please take a look when you can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the age of this PR I've gone ahead and pushed the fixes I would've generally suggested in a review. These changes include:
- Fixing the broken
bash
code-block that was causing the build to fail. - Removing the
---
transitions that were causing the build to fail. - Adding notebook metadata tags to the first cell.
- Removing the inline styling from headings.
- Removing heading blocks from text that weren't headings.
- Converted bolded "Note:" sections to MyST
```{note} ... ```
admonitions. - Fixed a URL that wasn't a link.
- Replaced the hard-coded container image with the
{{rapids_container}}
template.
I reviewed this notebook in three different ways in order to make these fixes:
- Read and googled errors from the failing build log, this found what needed to be changed to get the build passing.
- Opened the notebook in VSCode and reviewed the source, this identified things like the inline header styling and note sections.
- Viewed the rendered page and workflows gallery page from the ReadTheDocs build preview, this found things like the URL that wasn't a link and missing metadata tags.
Fixes #211 - migration of azure_mnmg_daskcloudprovider notebook
See #203 (comment) for detailed migration instructions.
Tasks