Fix code typo for Coiled #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melodywang060
approved these changes
Oct 9, 2024
| @@ -82,7 +82,7 @@ We can also connect a Dask client to see that information for the workers too. | |||
| ```python | |||
| from dask.distributed import Client | |||
|
|
|||
| client = Client | |||
| client = Client(cluster) | |||
There was a problem hiding this comment.
Coming around to this PR now as I'm going through the Coiled deployment process - is this example meant to be specific to the Jupyter server case, or more an illustration of how to connect a Dask client generally?
Depending on the answer, might be worth clarifying here that (the screenshot below seems to imply) we can just use Client() from the Jupyter server to automatically connect to the spawned cluster
There was a problem hiding this comment.
That's a good point. The correct fix here would've just been Client() because this was referring to using it within the Jupyter session. @charlesbluca would you mind making a follow-up PR here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a couple of small tweaks to the Coiled instructions.