Fix broken links and some typos #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ncclementi
commented
Oct 10, 2024
| @@ -277,7 +277,7 @@ | |||
| " \n", | |||
| "Optuna uses [studies](https://optuna.readthedocs.io/en/stable/reference/study.html) and [trials](https://optuna.readthedocs.io/en/stable/reference/trial.html) to keep track of the HPO experiments. Put simply, a trial is a single call of the objective function while a set of trials make up a study. We will pick the best observed trial from a study to get the best parameters that were used in that run.\n", | |||
| "\n", | |||
| "Here, `DaskStorage` class is used to set up a storage shared by all workers in the cluster. Learn more about what storages can be used [here](https://optuna.readthedocs.io/en/stable/tutorial/distributed.html)\n", | |||
| "Here, `DaskStorage` class is used to set up a storage shared by all workers in the cluster. Learn more about what storages can be used [here](https://optuna.readthedocs.io/en/stable/reference/storages.html)\n", | |||
There was a problem hiding this comment.
There is a new distributed tutorial in the optuna page see https://optuna.readthedocs.io/en/stable/tutorial/10_key_features/004_distributed.html, but it doesn't point to any storage docs, so I'm suggesting pointing to the storage docs. That being said, there is no reference there to DaskStorage since this is under optuna-integrations.
ncclementi
commented
Oct 10, 2024
| @@ -226,7 +226,7 @@ spec: | |||
| ``` | |||
|
|
|||
| For the scheduler pod we are also setting the `rapidsai/base` container image, mainly to ensure our Dask versions match between | |||
| the scheduler and workers. We also disable Jupyter and ensure that the `dask-scheduler` command is configured. | |||
| the scheduler and workers. We ensure that the `dask-scheduler` command is configured. | |||
There was a problem hiding this comment.
I think there is something missing in the yaml file that actually disables Jupyter, but it's not clear to me. Please correct if I'm wrong.
|
The CI failure is related to #463. there is a problem with the new sphinx release v8.1 |
ncclementi
force-pushed
the
broken-links
branch
from
fc73987
to
86035c4
Compare
jacobtomlinson
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going over the docs and found multiple broken links and some typos, so I went ahead and fix them. In some situations I wasn't sure about the correct link, please double check they are pointing to were they are supposed to.