Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image rendering in rapid-sagemaker-hpo notebook #472

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

ncclementi
Copy link
Contributor

@ncclementi ncclementi commented Oct 11, 2024

Closes #468

Let's give it a try and see what happens in the rendering when using markdown-style hyperlinks.

Edit: I check the read the doc link and looks like it works 🚀

@ncclementi ncclementi requested a review from a team as a code owner October 11, 2024 15:51
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jameslamb jameslamb added the cloud/aws Amazon Web Service cloud label Oct 11, 2024
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good to me in the docs too.

And I checked the repo for other stuff like this, didn't find any more.

git grep -E 'img.*src'

Appreciate the help!

@jameslamb jameslamb merged commit aff4061 into rapidsai:main Oct 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud/aws Amazon Web Service cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images not rendering in rapids-sagemaker-hpo notebook
2 participants