Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorporate build condition for raft-cpu-image in multi-arch job #706

Merged
merged 3 commits into from
Aug 13, 2024
Merged

incorporate build condition for raft-cpu-image in multi-arch job #706

merged 3 commits into from
Aug 13, 2024

Conversation

AyodeAwe
Copy link
Contributor

@AyodeAwe AyodeAwe commented Aug 8, 2024

Accounts for this condition for the multiach-manifest job.

@AyodeAwe AyodeAwe requested a review from a team as a code owner August 8, 2024 18:31
@AyodeAwe AyodeAwe requested review from jameslamb and removed request for a team August 8, 2024 18:31
@AyodeAwe AyodeAwe changed the base branch from branch-24.08 to branch-24.10 August 8, 2024 18:39
@AyodeAwe AyodeAwe force-pushed the conditionally-check-for-raft-cpu-image branch from 41701f8 to 5669110 Compare August 8, 2024 18:54
jameslamb
jameslamb requested changes Aug 9, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion for your consideration.

.github/workflows/build-test-publish-images.yml Outdated Show resolved Hide resolved
@jameslamb jameslamb mentioned this pull request Aug 9, 2024
Merged
rapids-bot bot pushed a commit that referenced this pull request Aug 12, 2024
@jameslamb
resolve warnings about Dockerfile casing (#707)
9d9b05a 
Reviewing #706, I noticed the following on the Files tab (https://github.com/rapidsai/docker/pull/706/files):

> FromAsCasing: 'as' and 'FROM' keywords' casing do not match
> More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

<img width="1285" alt="image" src="https://github.com/user-attachments/assets/66191c7f-77d9-415c-b965-b7e039df49fa">

This resolves those warnings. They don't change anything functionally, but I do slightly agree with the style suggestion, and it'd be nice to remove the visual noise of all those warnings in PR reviews.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #707
@AyodeAwe AyodeAwe force-pushed the conditionally-check-for-raft-cpu-image branch from e50b55c to d168627 Compare August 12, 2024 18:22
jameslamb
jameslamb reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Now that I see this happening down in a .jq script, proposed one more change for your consideration.

ci/compute-matrix.jq Outdated Show resolved Hide resolved
jameslamb
jameslamb approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes look good to me, hopefully we'll get a successful CI run to verify that the filter worked as expected. Looks like the recent builds mostly failed with network-related issues.

@AyodeAwe
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 54d6dd0 into rapidsai:branch-24.10 Aug 13, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyodeAwe @raydouglass @jameslamb