Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cuda-python and cudatoolkit from rapids metapackage. #695

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Remove cuda-python and cudatoolkit from rapids metapackage. #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions conda/recipes/rapids/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ requirements:
- cuda-version ={{ cuda_version }}
run:
- {{ pin_compatible('cuda-version', max_pin='x', min_pin='x') }}
{% if cuda_major == "11" %}
- cuda-python {{ cuda11_cuda_python_version }}
- cudatoolkit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking... was removing cudatoolkit for CUDA 11.x packages also intentional here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this in the description:

I also removed cudatoolkit because that is a transitive dependency of RAPIDS libraries, and only needed for CUDA 11

But this is in a block that's CUDA-11-specific.

Copy link
Contributor Author

@bdice bdice Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was intentional. We can revert that change if we want to keep this PR narrower, but it falls into the same bucket of "don't put packages in the rapids metapackage if we expect them to be supplied transitively by RAPIDS libraries, because it has the potential to make the solver do bad things with its priorities."

There are other packages that also fall in this category, like ptxcompiler (which is a hard dependency of cudf's CUDA 11 package).

The rapids metapackage (imo) should be only RAPIDS libraries, plus any other constraints needed to make the environment simpler for conda/mamba to resolve or more reproducible. If others agree, we could remove things like numba, numpy, etc. and rely on RAPIDS libraries to pin their own compatible versions of those. We certainly don't want the rapids metapackage to make the pinnings for packages like those any tighter than what RAPIDS libraries collectively support.

Changes of that scale would require careful testing, and wouldn't be suitable for 24.02.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thank you for that explanation! Just wanted to double-check that this was intentional, and that I understood it fully.

{% else %}
- cuda-python {{ cuda12_cuda_python_version }}
{% endif %}
- cupy {{ cupy_version }}
- nccl {{ nccl_version }}
- networkx {{ networkx_version }}
Expand Down
4 changes: 0 additions & 4 deletions conda/recipes/versions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
xgboost_version:
- '=2.0.3'

cuda11_cuda_python_version:
- '>=11.7.1,<12.0a'
cuda12_cuda_python_version:
- '>=12.0.0,<13.0a'
cupy_version:
- '>=12.0.0'
nccl_version:
Expand Down
Loading