Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to nvcomp 3.0.6. #346

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Bump to nvcomp 3.0.6. #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4322923
Bump to nvcomp 3.0.6.
bdice Feb 23, 2024
c008d64
Remove extraneous cudf dependency.
bdice Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions ci/release/update-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Copyright (c) 2022-2023, NVIDIA CORPORATION.
# Copyright (c) 2022-2024, NVIDIA CORPORATION.
##########################
# KvikIO Version Updater #
##########################
Expand Down Expand Up @@ -60,15 +60,6 @@ sed_runner 's/PROJECT_NUMBER = .*/PROJECT_NUMBER = '${NEXT_FULL_
sed_runner 's/version = .*/version = '"'${NEXT_SHORT_TAG}'"'/g' docs/source/conf.py
sed_runner 's/release = .*/release = '"'${NEXT_FULL_TAG}'"'/g' docs/source/conf.py

DEPENDENCIES=(
cudf
)
for DEP in "${DEPENDENCIES[@]}"; do
for FILE in dependencies.yaml conda/environments/*.yaml; do
sed_runner "/-.* ${DEP}==/ s/==.*/==${NEXT_SHORT_TAG_PEP440}.*/g" ${FILE}
done
done

# CI files
for FILE in .github/workflows/*.yaml; do
sed_runner "/shared-workflows/ s/@.*/@branch-${NEXT_SHORT_TAG}/g" "${FILE}"
Expand Down
3 changes: 1 addition & 2 deletions conda/environments/all_cuda-118_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ dependencies:
- cuda-python>=11.7.1,<12.0a0
- cuda-version=11.8
- cudatoolkit
- cudf==24.2.*
- cupy>=12.0.0
- cxx-compiler
- cython>=3.0.0
Expand All @@ -26,7 +25,7 @@ dependencies:
- numpy>=1.21
- numpydoc
- nvcc_linux-64=11.8
- nvcomp==3.0.5
- nvcomp==3.0.6
- packaging
- pre-commit
- pytest
Expand Down
3 changes: 1 addition & 2 deletions conda/environments/all_cuda-120_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ dependencies:
- cuda-nvcc
- cuda-python>=12.0,<13.0a0
- cuda-version=12.0
- cudf==24.2.*
- cupy>=12.0.0
- cxx-compiler
- cython>=3.0.0
Expand All @@ -25,7 +24,7 @@ dependencies:
- numcodecs <0.12.0
- numpy>=1.21
- numpydoc
- nvcomp==3.0.5
- nvcomp==3.0.6
- packaging
- pre-commit
- pytest
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/kvikio/conda_build_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ cmake_version:
- ">=3.26.4"

nvcomp_version:
- "=3.0.5"
- "=3.0.6"
8 changes: 1 addition & 7 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ files:
- cuda
- cuda_version
- docs
- notebooks
- py_version
- run
- test_python
Expand Down Expand Up @@ -173,7 +172,7 @@ dependencies:
common:
- output_types: conda
packages:
- nvcomp==3.0.5
- nvcomp==3.0.6
specific:
- output_types: conda
matrices:
Expand Down Expand Up @@ -283,8 +282,3 @@ dependencies:
packages:
- *dask
- distributed>=2022.05.2
notebooks:
common:
- output_types: conda
packages:
- cudf==24.2.*
Copy link
Contributor Author

@bdice bdice Feb 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no references to cudf in the notebooks, so I removed this. This dependency was causing devcontainer builds to fail due to conflicting nvcomp versions. This has been a pain in the past because it introduced a circular dependency between kvikio and cudf, but it seems safe to remove now.

Loading