Add support for Python 3.11, require NumPy 1.23+ #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
DO NOT MERGE
non-breaking
8 tasks
KyleFromNVIDIA
approved these changes
Feb 27, 2024
madsbk
approved these changes
Feb 27, 2024
KyleFromNVIDIA
approved these changes
Feb 27, 2024
|
I merged the upstream to fix conflicts with #345. |
bdice
approved these changes
Feb 27, 2024
AyodeAwe
approved these changes
Feb 27, 2024
|
Since Python 3.11 requires NumPy 1.23 at a minimum ( rapidsai/cucim#704 (comment) ), should we update lines like this one? Line 241 in 27abc15 Also noticing that NumPy 1.20 is being used here, which needs an update kvikio/conda/recipes/kvikio/meta.yaml Line 72 in 27abc15 |
|
Just pushed a commit updated to |
jameslamb
changed the title
|
/merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#3
This PR adds support for Python 3.11.
It also bumps uses of
NumPytonumpy>=1.23, see rapidsai/build-planning#3 (comment).Notes for Reviewers
This is part of ongoing work to add Python 3.11 support across RAPIDS.
The Python 3.11 CI workflows introduced in rapidsai/shared-workflows#176 are optional... they are not yet required to run successfully for PRs to be merged.
This PR can be merged once all jobs are running successfully (including the non-required jobs for Python 3.11). The CI logs should be verified that the jobs are building and testing with Python 3.11.
See rapidsai/shared-workflows#176 for more details.