Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip cufile and nvtx3 when cuda isn't found #455

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Sep 4, 2024

Closes #444

@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 4, 2024
@madsbk madsbk mentioned this pull request Sep 4, 2024
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
INSTALL_EXPORT_SET kvikio-exports
)
if(NOT cuFile_FOUND)
message(WARNING "Building KvikIO without cuFile")
Copy link

@Jacobfaib Jacobfaib Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this is still a bit too verbose. As a user, I don't quite know what to do with this information. So I don't have cuFile, do I want it? If so, how do I get it? And what happens if I don't have it?

I'm not saying you need to provide explicit download and install instructions for it etc. but if you are going to raise a big scary warning about it, it would be nice to have some kind of explanation :)1.

Note that CUDAToolKit will automatically come shipped with cuFile.

My suggestion would be either:

  • Consider making this a hard error instead (i.e. REQUIRED).
  • Or giving the user some way to silence the warning (KvikIO_SILENCE_MISSING_CUFILE or something like that).

Footnotes

  1. Also consider the case where I know I definitely don't want cuFile (for whatever reason), there is no way to silence this warning. Now suppose I want to run my cmake files using -Werror (to catch cmake warnings), I have no way of doing that with this warning.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you point but let's add explicit options in another PR: #459.
For now, I have added:

message(
  WARNING "Cannot find cuFile - KvikIO will still work but won't use GPUDirect Storage (GDS)"
)

@madsbk madsbk marked this pull request as ready for review September 5, 2024 10:29
@madsbk madsbk requested a review from a team as a code owner September 5, 2024 10:29
@madsbk madsbk closed this Sep 16, 2024
@madsbk madsbk deleted the cpu-only-build-less-verbose branch September 16, 2024 19:23
@madsbk madsbk restored the cpu-only-build-less-verbose branch September 16, 2024 20:53
@madsbk madsbk reopened this Sep 16, 2024
@madsbk
Copy link
Member Author

madsbk commented Sep 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit e926fad into rapidsai:branch-24.10 Sep 19, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very Chatty CPU-only Build
3 participants