Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvtx support macos #474

Merged
merged 2 commits into from
Sep 30, 2024
Merged

nvtx support macos #474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a28d806
KVIKIO_NVTX_FUNC_RANGE(): use convert_to_64bit
madsbk Sep 25, 2024
439f59f
use constexpr
madsbk Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion cpp/include/kvikio/utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
#include <iostream>
#include <map>
#include <optional>
#include <stdexcept>
#include <tuple>
#include <type_traits>

#include <nvtx3/nvtx3.hpp>

Expand Down Expand Up @@ -69,6 +71,29 @@ inline constexpr std::size_t page_size = 4096;
return reinterpret_cast<CUdeviceptr>(devPtr);
}

/**
* @brief Help function to convert value to 64 bit signed integer
*/
template <typename T, std::enable_if_t<std::is_integral_v<T>>* = nullptr>
[[nodiscard]] std::int64_t convert_to_64bit(T value)
{
if constexpr (std::numeric_limits<T>::max() > std::numeric_limits<std::int64_t>::max()) {
if (value > std::numeric_limits<std::int64_t>::max()) {
throw std::overflow_error("convert_to_64bit(x): x too large to fit std::int64_t");
}
}
return std::int64_t(value);
}

/**
* @brief Help function to convert value to 64 bit float
*/
template <typename T, std::enable_if_t<std::is_floating_point_v<T>>* = nullptr>
[[nodiscard]] double convert_to_64bit(T value)
{
return double(value);
}

/**
* @brief Check if `ptr` points to host memory (as opposed to device memory)
*
Expand Down Expand Up @@ -280,7 +305,7 @@ struct libkvikio_domain {
{ \
nvtx3::event_attributes \
{ \
msg, nvtx3::payload { val } \
msg, nvtx3::payload { convert_to_64bit(val) } \
} \
}
#define GET_KVIKIO_NVTX_FUNC_RANGE_MACRO(_1, _2, NAME, ...) NAME
Expand Down