[FEA] Statically link liblapack and CTK libs, fix runtime images (#422)

* fix issue where images weren't all rebuilding on version bumps * add missing core cuda and rmm libs to runtime images * add clean:build and tsc:clean npm package scripts * set CMake policies, statically link liblapack and libblas * rebuild images if lerna.json changes
rapidsai · Aug 26, 2022 · ce0fdb3 · ce0fdb3
1 parent b100f6b
commit ce0fdb3
Show file tree

Hide file tree

Showing 41 changed files with 285 additions and 176 deletions.
diff --git a/.github/workflows/build-and-push-image-ssh.yml b/.github/workflows/build-and-push-image-ssh.yml
@@ -114,6 +114,7 @@ jobs:
           files: |
             ${{ inputs.file }}
             ${{ inputs.files-to-diff }}
+            lerna\.json
             \.github/workflows/merge\.pr\.yml
             \.github/workflows/build-and-push-image\.yml
             \.github/actions/build-and-publish-image-ssh/action\.yml

diff --git a/.github/workflows/build-and-push-image.yml b/.github/workflows/build-and-push-image.yml
@@ -105,6 +105,7 @@ jobs:
           files: |
             ${{ inputs.file }}
             ${{ inputs.files-to-diff }}
+            lerna\.json
             \.github/workflows/merge\.pr\.yml
             \.github/workflows/build-and-push-image\.yml
             \.github/actions/build-and-publish-image/action\.yml

diff --git a/.github/workflows/merge.pr.yml b/.github/workflows/merge.pr.yml
@@ -24,7 +24,6 @@ jobs:
         \.npmrc
         modules
         yarn\.lock
-        package\.json
       build-args: |
         "UCX_VERSION=1.12.1"
 
@@ -43,7 +42,6 @@ jobs:
         \.npmrc
         modules
         yarn\.lock
-        package\.json
         dev/dockerfiles/devel/main\.Dockerfile
       build-args: |
         "CUDAARCHS=ALL"

diff --git a/dev/dockerfiles/devel/main.Dockerfile b/dev/dockerfiles/devel/main.Dockerfile
@@ -37,6 +37,7 @@ ${CUDA_HOME}/nvvm/lib64:\
 ${CUDA_HOME}/lib64/stubs"
 
 ARG GCC_VERSION=9
+ARG CMAKE_VERSION=3.24.1
 ARG SCCACHE_VERSION=0.2.15
 ARG LINUX_VERSION=ubuntu20.04
 
@@ -71,8 +72,13 @@ deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitw
  \
  && apt update \
  && apt install --no-install-recommends -y \
-    git cmake ninja-build \
+    git \
+    # Needed for CMake to find static `liblapack.a`
+    gfortran \
+    ninja-build \
     gcc-${GCC_VERSION} g++-${GCC_VERSION} gdb \
+    cmake=${CMAKE_VERSION}-0kitware1${LINUX_VERSION}.1 \
+    cmake-data=${CMAKE_VERSION}-0kitware1${LINUX_VERSION}.1 \
     curl libssl-dev libcurl4-openssl-dev xz-utils zlib1g-dev liblz4-dev \
     # From opengl/glvnd:devel
     pkg-config \

diff --git a/dev/dockerfiles/runtime/cudf.Dockerfile b/dev/dockerfiles/runtime/cudf.Dockerfile
@@ -17,7 +17,7 @@ RUN --mount=type=bind,from=build,source=/opt/rapids/,target=/tmp/rapids/ \
         /tmp/rapids/rapidsai-cuda-*.tgz  \
         /tmp/rapids/rapidsai-rmm-*.tgz   \
         /tmp/rapids/rapidsai-cudf-*.tgz; \
-    for x in cudf; do \
+    for x in core cuda rmm cudf; do \
         mkdir node_modules/@rapidsai/${x}/build/Release; \
         tar -C node_modules/@rapidsai/${x}/build/Release \
             -f /tmp/rapids/rapidsai_${x}-*-Linux.tar.gz \

diff --git a/dev/dockerfiles/runtime/cugraph.Dockerfile b/dev/dockerfiles/runtime/cugraph.Dockerfile
@@ -18,7 +18,7 @@ RUN --mount=type=bind,from=build,source=/opt/rapids/,target=/tmp/rapids/ \
         /tmp/rapids/rapidsai-rmm-*.tgz      \
         /tmp/rapids/rapidsai-cudf-*.tgz     \
         /tmp/rapids/rapidsai-cugraph-*.tgz; \
-    for x in cudf cugraph; do \
+    for x in core cuda rmm cudf cugraph; do \
         mkdir node_modules/@rapidsai/${x}/build/Release; \
         tar -C node_modules/@rapidsai/${x}/build/Release \
             -f /tmp/rapids/rapidsai_${x}-*-Linux.tar.gz \

diff --git a/dev/dockerfiles/runtime/cuml.Dockerfile b/dev/dockerfiles/runtime/cuml.Dockerfile
@@ -18,7 +18,7 @@ RUN --mount=type=bind,from=build,source=/opt/rapids/,target=/tmp/rapids/ \
         /tmp/rapids/rapidsai-rmm-*.tgz   \
         /tmp/rapids/rapidsai-cudf-*.tgz  \
         /tmp/rapids/rapidsai-cuml-*.tgz; \
-    for x in cudf cuml; do \
+    for x in core cuda rmm cudf cuml; do \
         mkdir node_modules/@rapidsai/${x}/build/Release; \
         tar -C node_modules/@rapidsai/${x}/build/Release \
             -f /tmp/rapids/rapidsai_${x}-*-Linux.tar.gz \

diff --git a/dev/dockerfiles/runtime/cuspatial.Dockerfile b/dev/dockerfiles/runtime/cuspatial.Dockerfile
@@ -18,7 +18,7 @@ RUN --mount=type=bind,from=build,source=/opt/rapids/,target=/tmp/rapids/ \
         /tmp/rapids/rapidsai-rmm-*.tgz        \
         /tmp/rapids/rapidsai-cudf-*.tgz       \
         /tmp/rapids/rapidsai-cuspatial-*.tgz; \
-    for x in cudf cuspatial; do \
+    for x in core cuda rmm cudf cuspatial; do \
         mkdir node_modules/@rapidsai/${x}/build/Release; \
         tar -C node_modules/@rapidsai/${x}/build/Release \
             -f /tmp/rapids/rapidsai_${x}-*-Linux.tar.gz \

diff --git a/dev/dockerfiles/runtime/demo.Dockerfile b/dev/dockerfiles/runtime/demo.Dockerfile
@@ -28,7 +28,7 @@ RUN --mount=type=bind,from=build,source=/opt/rapids/,target=/tmp/rapids/ \
         /tmp/rapids/rapidsai-deck.gl-*.tgz   \
         /tmp/rapids/rapidsai-jsdom-*.tgz     \
         /tmp/rapids/rapidsai-demo-*.tgz;     \
-    for x in cudf cuml cugraph cuspatial sql io; do \
+    for x in core cuda rmm cudf cuml cugraph cuspatial sql io; do \
         mkdir node_modules/@rapidsai/${x}/build/Release; \
         tar -C node_modules/@rapidsai/${x}/build/Release \
             -f /tmp/rapids/rapidsai_${x}-*-Linux.tar.gz \

diff --git a/dev/dockerfiles/runtime/main.Dockerfile b/dev/dockerfiles/runtime/main.Dockerfile
@@ -27,7 +27,7 @@ RUN --mount=type=bind,from=build,source=/opt/rapids/,target=/tmp/rapids/ \
         /tmp/rapids/rapidsai-io-*.tgz        \
         /tmp/rapids/rapidsai-deck.gl-*.tgz   \
         /tmp/rapids/rapidsai-jsdom-*.tgz;    \
-    for x in cudf cuml cugraph cuspatial sql io; do \
+    for x in core cuda rmm cudf cuml cugraph cuspatial sql io; do \
         mkdir node_modules/@rapidsai/${x}/build/Release; \
         tar -C node_modules/@rapidsai/${x}/build/Release \
             -f /tmp/rapids/rapidsai_${x}-*-Linux.tar.gz \

diff --git a/dev/dockerfiles/runtime/sql.Dockerfile b/dev/dockerfiles/runtime/sql.Dockerfile
@@ -18,7 +18,7 @@ RUN --mount=type=bind,from=build,source=/opt/rapids/,target=/tmp/rapids/ \
         /tmp/rapids/rapidsai-rmm-*.tgz  \
         /tmp/rapids/rapidsai-cudf-*.tgz \
         /tmp/rapids/rapidsai-sql-*.tgz; \
-    for x in cudf sql; do \
+    for x in core cuda rmm cudf sql; do \
         mkdir node_modules/@rapidsai/${x}/build/Release; \
         tar -C node_modules/@rapidsai/${x}/build/Release \
             -f /tmp/rapids/rapidsai_${x}-*-Linux.tar.gz \

diff --git a/modules/core/CMakeLists.txt b/modules/core/CMakeLists.txt
@@ -13,9 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #=============================================================================
-cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
-
-project(rapidsai_core VERSION $ENV{npm_package_version} LANGUAGES C CXX)
+cmake_minimum_required(VERSION 3.24.1 FATAL_ERROR)
 
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 unset(CMAKE_LIBRARY_OUTPUT_DIRECTORY)
@@ -32,6 +30,10 @@ execute_process(COMMAND node -p
                 OUTPUT_VARIABLE NODE_RAPIDS_CMAKE_MODULES_PATH
                 OUTPUT_STRIP_TRAILING_WHITESPACE)
 
+include("${NODE_RAPIDS_CMAKE_MODULES_PATH}/cmake_policies.cmake")
+
+project(rapidsai_core VERSION $ENV{npm_package_version} LANGUAGES C CXX)
+
 include("${NODE_RAPIDS_CMAKE_MODULES_PATH}/ConfigureCXX.cmake")
 include("${NODE_RAPIDS_CMAKE_MODULES_PATH}/ConfigureCUDA.cmake")
 include("${NODE_RAPIDS_CMAKE_MODULES_PATH}/ConfigureNapi.cmake")

diff --git a/modules/core/cmake/Modules/ConfigureCUDA.cmake b/modules/core/cmake/Modules/ConfigureCUDA.cmake
@@ -117,6 +117,7 @@ message(STATUS "CMAKE_CUDA_ARCHITECTURES: ${CMAKE_CUDA_ARCHITECTURES}")
 # Override the cached version from enable_language(CUDA)
 set(CMAKE_CUDA_ARCHITECTURES "${CMAKE_CUDA_ARCHITECTURES}" CACHE STRING "" FORCE)
 
+set(BLA_STATIC ON)
 set(CUDA_STATIC_RUNTIME ON)
 set(CUDA_USE_STATIC_CUDA_RUNTIME ON)
 set(CMAKE_CUDA_RUNTIME_LIBRARY STATIC)

diff --git a/modules/core/cmake/Modules/cmake_policies.cmake b/modules/core/cmake/Modules/cmake_policies.cmake
@@ -0,0 +1,44 @@
+#=============================================================================
+# Copyright (c) 2020-2022, NVIDIA CORPORATION.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#=============================================================================
+include_guard(GLOBAL)
+
+if(POLICY CMP0072)
+  # Set OpenGL_GL_PREFERENCE to "GLVND"
+  # https://cmake.org/cmake/help/latest/policy/CMP0072.html#policy:CMP0072
+  cmake_policy(SET CMP0072 NEW)
+  set(CMAKE_POLICY_DEFAULT_CMP0072 NEW)
+endif()
+
+if(POLICY CMP0102)
+  # empty cache variable sets
+  # https://cmake.org/cmake/help/latest/policy/CMP0102.html#policy:CMP0102
+  cmake_policy(SET CMP0102 NEW)
+  set(CMAKE_POLICY_DEFAULT_CMP0102 NEW)
+endif()
+
+if(POLICY CMP0124)
+  # unset loop variables
+  # https://cmake.org/cmake/help/latest/policy/CMP0124.html#policy:CMP0124
+  cmake_policy(SET CMP0124 NEW)
+  set(CMAKE_POLICY_DEFAULT_CMP0124 NEW)
+endif()
+
+if(POLICY CMP0126)
+  # make set(CACHE) command not remove normal variable of the same name from the current scope
+  # https://cmake.org/cmake/help/latest/policy/CMP0126.html
+  cmake_policy(SET CMP0126 NEW)
+  set(CMAKE_POLICY_DEFAULT_CMP0126 NEW)
+endif()
diff --git a/modules/core/cmake/Modules/link_utils.cmake b/modules/core/cmake/Modules/link_utils.cmake
@@ -27,9 +27,10 @@ function(_statically_link_cuda_toolkit_libs target)
 
     get_target_property(_link_libs ${target} INTERFACE_LINK_LIBRARIES)
 
-    foreach(_lib IN ITEMS cublas cublasLt cudart cufft cufft cufftw cupti curand cusolver
-                          cusolver_lapack cusolver_metis cusparse nppc nppial nppicc nppicom
-                          nppidei nppif nppig nppim nppist nppisu nppitc npps nvgraph)
+    foreach(_lib IN ITEMS blas cublas cublasLt cudart cufft cufft cufftw cupti curand
+                          cusolver cusolver_lapack cusolver_metis cusparse lapack nppc
+                          nppial nppicc nppicom nppidei nppif nppig nppim nppist nppisu
+                          nppitc npps nvgraph)
       string(REPLACE "CUDA::${_lib};" "CUDA::${_lib}_static;" _link_libs "${_link_libs}")
       string(REPLACE "CUDA::${_lib}>" "CUDA::${_lib}_static>" _link_libs "${_link_libs}")
       string(REPLACE "CUDA::${_lib}\"" "CUDA::${_lib}_static\"" _link_libs "${_link_libs}")

diff --git a/modules/core/package.json b/modules/core/package.json
@@ -43,8 +43,9 @@
     "cpp:rebuild:debug": "nvidia-cmake-js rebuild -g -D",
     "cpp:reconfigure": "yarn cpp:clean && nvidia-cmake-js configure -g",
     "cpp:reconfigure:debug": "yarn cpp:clean && nvidia-cmake-js configure -g -D",
-    "tsc:build": "rimraf build/js && tsc -p ./tsconfig.json",
-    "tsc:watch": "rimraf build/js && tsc -p ./tsconfig.json -w",
+    "tsc:clean": "rimraf build/js",
+    "tsc:build": "yarn tsc:clean && tsc -p ./tsconfig.json",
+    "tsc:watch": "yarn tsc:clean && tsc -p ./tsconfig.json -w",
     "dev:cpack": "cd build/Release && cpack -G TGZ >/dev/null && echo \"$(realpath -m ./rapidsai_*-*-*.tar.gz)\""
   },
   "dependencies": {

diff --git a/modules/cuda/CMakeLists.txt b/modules/cuda/CMakeLists.txt
@@ -13,9 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #=============================================================================
-cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
-
-project(rapidsai_cuda VERSION $ENV{npm_package_version} LANGUAGES C CXX)
+cmake_minimum_required(VERSION 3.24.1 FATAL_ERROR)
 
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 unset(CMAKE_LIBRARY_OUTPUT_DIRECTORY)
@@ -32,6 +30,10 @@ execute_process(COMMAND node -p
                 OUTPUT_VARIABLE NODE_RAPIDS_CMAKE_MODULES_PATH
                 OUTPUT_STRIP_TRAILING_WHITESPACE)
 
+include("${NODE_RAPIDS_CMAKE_MODULES_PATH}/cmake_policies.cmake")
+
+project(rapidsai_cuda VERSION $ENV{npm_package_version} LANGUAGES C CXX)
+
 execute_process(COMMAND node -p
                 "require('path').dirname(require.resolve('@rapidsai/core'))"
                 WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"

diff --git a/modules/cuda/package.json b/modules/cuda/package.json
@@ -40,8 +40,9 @@
     "cpp:rebuild:debug": "nvidia-cmake-js rebuild -g -D",
     "cpp:reconfigure": "yarn cpp:clean && nvidia-cmake-js configure -g",
     "cpp:reconfigure:debug": "yarn cpp:clean && nvidia-cmake-js configure -g -D",
-    "tsc:build": "rimraf build/js && tsc -p ./tsconfig.json",
-    "tsc:watch": "rimraf build/js && tsc -p ./tsconfig.json -w",
+    "tsc:clean": "rimraf build/js",
+    "tsc:build": "yarn tsc:clean && tsc -p ./tsconfig.json",
+    "tsc:watch": "yarn tsc:clean && tsc -p ./tsconfig.json -w",
     "dev:cpack": "cd build/Release && cpack -G TGZ >/dev/null && echo \"$(realpath -m ./rapidsai_*-*-*.tar.gz)\""
   },
   "dependencies": {

diff --git a/modules/cudf/CMakeLists.txt b/modules/cudf/CMakeLists.txt
@@ -13,9 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #=============================================================================
-cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
-
-project(rapidsai_cudf VERSION $ENV{npm_package_version} LANGUAGES C CXX)
+cmake_minimum_required(VERSION 3.24.1 FATAL_ERROR)
 
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 unset(CMAKE_LIBRARY_OUTPUT_DIRECTORY)
@@ -32,6 +30,10 @@ execute_process(COMMAND node -p
                 OUTPUT_VARIABLE NODE_RAPIDS_CMAKE_MODULES_PATH
                 OUTPUT_STRIP_TRAILING_WHITESPACE)
 
+include("${NODE_RAPIDS_CMAKE_MODULES_PATH}/cmake_policies.cmake")
+
+project(rapidsai_cudf VERSION $ENV{npm_package_version} LANGUAGES C CXX)
+
 execute_process(COMMAND node -p
                 "require('path').dirname(require.resolve('@rapidsai/core'))"
                 WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"

diff --git a/modules/cudf/package.json b/modules/cudf/package.json
@@ -40,8 +40,9 @@
     "cpp:rebuild:debug": "nvidia-cmake-js rebuild -g -D",
     "cpp:reconfigure": "yarn cpp:clean && nvidia-cmake-js configure -g",
     "cpp:reconfigure:debug": "yarn cpp:clean && nvidia-cmake-js configure -g -D",
-    "tsc:build": "rimraf build/js && tsc -p ./tsconfig.json",
-    "tsc:watch": "rimraf build/js && tsc -p ./tsconfig.json -w",
+    "tsc:clean": "rimraf build/js",
+    "tsc:build": "yarn tsc:clean && tsc -p ./tsconfig.json",
+    "tsc:watch": "yarn tsc:clean && tsc -p ./tsconfig.json -w",
     "dev:cpack": "cd build/Release && cpack -G TGZ >/dev/null && echo \"$(realpath -m ./rapidsai_*-*-*.tar.gz)\""
   },
   "dependencies": {

diff --git a/modules/cugraph/CMakeLists.txt b/modules/cugraph/CMakeLists.txt
@@ -13,13 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #=============================================================================
-cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
-
-project(rapidsai_cugraph VERSION $ENV{npm_package_version} LANGUAGES C CXX)
-
-if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64")
-    return()
-endif()
+cmake_minimum_required(VERSION 3.24.1 FATAL_ERROR)
 
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 unset(CMAKE_LIBRARY_OUTPUT_DIRECTORY)
@@ -36,6 +30,14 @@ execute_process(COMMAND node -p
                 OUTPUT_VARIABLE NODE_RAPIDS_CMAKE_MODULES_PATH
                 OUTPUT_STRIP_TRAILING_WHITESPACE)
 
+include("${NODE_RAPIDS_CMAKE_MODULES_PATH}/cmake_policies.cmake")
+
+project(rapidsai_cugraph VERSION $ENV{npm_package_version} LANGUAGES C CXX)
+
+if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64")
+    return()
+endif()
+
 execute_process(COMMAND node -p
                 "require('path').dirname(require.resolve('@rapidsai/core'))"
                 WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"

diff --git a/modules/cugraph/package.json b/modules/cugraph/package.json
@@ -40,8 +40,9 @@
     "cpp:rebuild:debug": "nvidia-cmake-js rebuild -g -D",
     "cpp:reconfigure": "yarn cpp:clean && nvidia-cmake-js configure -g",
     "cpp:reconfigure:debug": "yarn cpp:clean && nvidia-cmake-js configure -g -D",
-    "tsc:build": "rimraf build/js && tsc -p ./tsconfig.json",
-    "tsc:watch": "rimraf build/js && tsc -p ./tsconfig.json -w",
+    "tsc:clean": "rimraf build/js",
+    "tsc:build": "yarn tsc:clean && tsc -p ./tsconfig.json",
+    "tsc:watch": "yarn tsc:clean && tsc -p ./tsconfig.json -w",
     "dev:cpack": "cd build/Release && cpack -G TGZ >/dev/null && echo \"$(realpath -m ./rapidsai_*-*-*.tar.gz)\""
   },
   "dependencies": {

diff --git a/modules/cuml/CMakeLists.txt b/modules/cuml/CMakeLists.txt
@@ -13,13 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #=============================================================================
-cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
-
-project(rapidsai_cuml VERSION $ENV{npm_package_version} LANGUAGES C CXX)
-
-if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64")
-    return()
-endif()
+cmake_minimum_required(VERSION 3.24.1 FATAL_ERROR)
 
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 unset(CMAKE_LIBRARY_OUTPUT_DIRECTORY)
@@ -36,6 +30,14 @@ execute_process(COMMAND node -p
                 OUTPUT_VARIABLE NODE_RAPIDS_CMAKE_MODULES_PATH
                 OUTPUT_STRIP_TRAILING_WHITESPACE)
 
+include("${NODE_RAPIDS_CMAKE_MODULES_PATH}/cmake_policies.cmake")
+
+project(rapidsai_cuml VERSION $ENV{npm_package_version} LANGUAGES C CXX)
+
+if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64")
+    return()
+endif()
+
 execute_process(COMMAND node -p
                 "require('path').dirname(require.resolve('@rapidsai/core'))"
                 WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"

diff --git a/modules/cuml/package.json b/modules/cuml/package.json
@@ -40,8 +40,9 @@
     "cpp:rebuild:debug": "nvidia-cmake-js rebuild -g -D",
     "cpp:reconfigure": "yarn cpp:clean && nvidia-cmake-js configure -g",
     "cpp:reconfigure:debug": "yarn cpp:clean && nvidia-cmake-js configure -g -D",
-    "tsc:build": "rimraf build/js && tsc -p ./tsconfig.json",
-    "tsc:watch": "rimraf build/js && tsc -p ./tsconfig.json -w",
+    "tsc:clean": "rimraf build/js",
+    "tsc:build": "yarn tsc:clean && tsc -p ./tsconfig.json",
+    "tsc:watch": "yarn tsc:clean && tsc -p ./tsconfig.json -w",
     "dev:cpack": "cd build/Release && cpack -G TGZ >/dev/null && echo \"$(realpath -m ./rapidsai_*-*-*.tar.gz)\""
   },
   "dependencies": {

diff --git a/modules/cuml/src/node_cuml/cuml/manifold/common.hpp b/modules/cuml/src/node_cuml/cuml/manifold/common.hpp
@@ -20,6 +20,8 @@
 #ifdef CHECK_CUDA
 #undef CHECK_CUDA
 #endif
+#include <cstddef>
+#include <cstdint>
 #include <cuml/manifold/common.hpp>
 #ifdef CHECK_CUDA
 #undef CHECK_CUDA