Update to CUDA 12.4 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Bradley! 🙏 Think we also need PR: conda-forge/cuda-nvcc-feedstock#37 Edit: Linking the CUDA Toolkit 12.4 tracking issue for reference: conda-forge/cuda-feedstock#17 |
|
Think we have what we need. Trying to restart CI |
|
Looks like the Conda builds completed successfully! 🎉 CI is still running |
|
Is it worth putting that in its own PR? Happy to merge that fix first |
|
I saw enough of the CI output. I pushed the fix for wheel tests so we are testing the actual CI artifacts rather than nightly packages. edit: Let's just do it in this PR. I don't want to open another one. |
jakirkham
reviewed
Mar 6, 2024
|
/merge |
|
Looks like we do this the old school way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates pynvjitlink to use CUDA 12.4. This depends on conda-forge/libnvjitlink-feedstock#9.